Skip to content

Commit b65d4ca

Browse files
Andrei Kuchynskigregkh
authored andcommitted
usb: typec: Remove alt->adev.dev.class assignment
The typec plug alternate mode is already registered as part of the bus. When both class and bus are set for a device, device_add() attempts to create the "subsystem" symlink in the device's sysfs directory twice, once for the bus and once for the class. This results in a duplicate filename error during registration, causing the alternate mode registration to fail with warnings: cannot create duplicate filename '/devices/pci0000:00/0000:00:1f.0/ PNP0C09:00/GOOG0004:00/cros-ec-dev.1.auto/cros_ec_ucsi.3.auto/typec/ port1/port1-cable/port1-plug0/port1-plug0.0/subsystem' typec port0-plug0: failed to register alternate mode (-17) cros_ec_ucsi.3.auto: failed to registers svid 0x8087 mode 1 Cc: stable <stable@kernel.org> Fixes: 67ab454 ("usb: typec: Set the bus also for the port and plug altmodes") Tested-by: Madhu M <madhu.m@intel.corp-partner.google.com> Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Benson Leung <bleung@chromium.org> Link: https://patch.msgid.link/20260324102903.1416210-1-akuchynski@chromium.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9bb4b5e commit b65d4ca

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/usb/typec/class.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -686,10 +686,6 @@ typec_register_altmode(struct device *parent,
686686

687687
alt->adev.dev.bus = &typec_bus;
688688

689-
/* Plug alt modes need a class to generate udev events. */
690-
if (is_typec_plug(parent))
691-
alt->adev.dev.class = &typec_class;
692-
693689
ret = device_register(&alt->adev.dev);
694690
if (ret) {
695691
dev_err(parent, "failed to register alternate mode (%d)\n",

0 commit comments

Comments
 (0)