Skip to content

Commit b522794

Browse files
tretterlag-linaro
authored andcommitted
leds: multicolor: Change intensity_value to unsigned int
Using min to compare the intensity_value with led_dev->max_brightness causes a signedness error: drivers/leds/led-class-multicolor.c: In function 'multi_intensity_store': ././include/linux/compiler_types.h:630:45: error: call to '__compiletime_assert_195' declared with attribute error: min(intensity_value[i], led_cdev->max_brightness) signedness error Change the type of intensity_value to unsigned int to fix the signedness error. intensity_value is used to set mcled_cdev->subled_info[i].intensity, which is unsigned int, too. Fixes: 129f82752bce ("leds: multicolor: Limit intensity to max_brightness of LED") Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> Link: https://patch.msgid.link/20260206-leds-multicolor-fix-signedness-error-v1-1-48a00ed33c07@pengutronix.de Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 6de23f8 commit b522794

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/leds/led-class-multicolor.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ static ssize_t multi_intensity_store(struct device *dev,
3434
struct led_classdev *led_cdev = dev_get_drvdata(dev);
3535
struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
3636
int nrchars, offset = 0;
37-
int intensity_value[LED_COLOR_ID_MAX];
37+
unsigned int intensity_value[LED_COLOR_ID_MAX];
3838
int i;
3939
ssize_t ret;
4040

4141
mutex_lock(&led_cdev->led_access);
4242

4343
for (i = 0; i < mcled_cdev->num_colors; i++) {
44-
ret = sscanf(buf + offset, "%i%n",
44+
ret = sscanf(buf + offset, "%u%n",
4545
&intensity_value[i], &nrchars);
4646
if (ret != 1) {
4747
ret = -EINVAL;

0 commit comments

Comments
 (0)