Skip to content

Commit b47ce58

Browse files
rddunlaptiwai
authored andcommitted
ALSA: hda - fix function names & missing function parameter
Use the correct function names and add a function parameter description to avoid kernel-doc warnings: hda_jack.h:97: warning: Function parameter or struct member 'cb' not described in 'snd_hda_jack_detect_enable_callback' hda_jack.h:97: warning: expecting prototype for snd_hda_jack_detect_enable(). Prototype was for snd_hda_jack_detect_enable_callback() instead hda_local.h:441: warning: expecting prototype for _snd_hda_set_pin_ctl(). Prototype was for snd_hda_set_pin_ctl() instead Fixes: cdd03ce ("ALSA: hda - Introduce snd_hda_set_pin_ctl*() helper functions") Fixes: 5204a05 ("ALSA: hda - Add DP-MST jack support") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Link: https://patch.msgid.link/20260106185951.2179242-1-rdunlap@infradead.org Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 0585c53 commit b47ce58

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

sound/hda/common/hda_jack.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ snd_hda_jack_detect_enable_callback_mst(struct hda_codec *codec, hda_nid_t nid,
8282
int dev_id, hda_jack_callback_fn func);
8383

8484
/**
85-
* snd_hda_jack_detect_enable - enable the jack-detection
85+
* snd_hda_jack_detect_enable_callback - enable the jack-detection
8686
* @codec: the HDA codec
8787
* @nid: pin NID to enable
88-
* @func: callback function to register
88+
* @cb: callback function to register
8989
*
9090
* In the case of error, the return value will be a pointer embedded with
9191
* errno. Check and handle the return value appropriately with standard

sound/hda/common/hda_local.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ int _snd_hda_set_pin_ctl(struct hda_codec *codec, hda_nid_t pin,
424424
unsigned int val, bool cached);
425425

426426
/**
427-
* _snd_hda_set_pin_ctl - Set a pin-control value safely
427+
* snd_hda_set_pin_ctl - Set a pin-control value safely
428428
* @codec: the codec instance
429429
* @pin: the pin NID to set the control
430430
* @val: the pin-control value (AC_PINCTL_* bits)

0 commit comments

Comments
 (0)