Skip to content

Commit ac1ff57

Browse files
04bariltiwai
authored andcommitted
ALSA: hda/realtek - Enable mute LEDs on HP ENVY x360 15-es0xxx
The mute and mic-mute LEDs on HP ENVY x360 Convertible 15-es0xxx (PCI SSID 103c:88b3) do not work with the current driver. This model requires a combination of COEFBIT and GPIO fixups to correctly control the LEDs. Introduce a new fixup function alc245_fixup_hp_envy_x360_mute_led and add a quirk to apply it. Signed-off-by: Illia Barbashyn <04baril@gmail.com> Link: https://patch.msgid.link/20260207221955.24132-1-04baril@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 1585cf8 commit ac1ff57

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

sound/hda/codecs/realtek/alc269.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1660,6 +1660,13 @@ static void alc285_fixup_hp_spectre_x360_mute_led(struct hda_codec *codec,
16601660
alc285_fixup_hp_gpio_micmute_led(codec, fix, action);
16611661
}
16621662

1663+
static void alc245_fixup_hp_envy_x360_mute_led(struct hda_codec *codec,
1664+
const struct hda_fixup *fix, int action)
1665+
{
1666+
alc245_fixup_hp_mute_led_v1_coefbit(codec, fix, action);
1667+
alc245_fixup_hp_gpio_led(codec, fix, action);
1668+
}
1669+
16631670
static void alc236_fixup_hp_mute_led(struct hda_codec *codec,
16641671
const struct hda_fixup *fix, int action)
16651672
{
@@ -3908,6 +3915,7 @@ enum {
39083915
ALC285_FIXUP_HP_GPIO_LED,
39093916
ALC285_FIXUP_HP_MUTE_LED,
39103917
ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED,
3918+
ALC245_FIXUP_HP_ENVY_X360_MUTE_LED,
39113919
ALC285_FIXUP_HP_BEEP_MICMUTE_LED,
39123920
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2,
39133921
ALC236_FIXUP_HP_GPIO_LED,
@@ -5546,6 +5554,10 @@ static const struct hda_fixup alc269_fixups[] = {
55465554
.type = HDA_FIXUP_FUNC,
55475555
.v.func = alc285_fixup_hp_spectre_x360_mute_led,
55485556
},
5557+
[ALC245_FIXUP_HP_ENVY_X360_MUTE_LED] = {
5558+
.type = HDA_FIXUP_FUNC,
5559+
.v.func = alc245_fixup_hp_envy_x360_mute_led,
5560+
},
55495561
[ALC285_FIXUP_HP_BEEP_MICMUTE_LED] = {
55505562
.type = HDA_FIXUP_FUNC,
55515563
.v.func = alc285_fixup_hp_beep,
@@ -6814,6 +6826,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
68146826
SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED),
68156827
SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
68166828
SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
6829+
SND_PCI_QUIRK(0x103c, 0x88b3, "HP ENVY x360 Convertible 15-es0xxx", ALC245_FIXUP_HP_ENVY_X360_MUTE_LED),
68176830
SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
68186831
SND_PCI_QUIRK(0x103c, 0x88dd, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
68196832
SND_PCI_QUIRK(0x103c, 0x88eb, "HP Victus 16-e0xxx", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),

0 commit comments

Comments
 (0)