Skip to content

Commit a9a9179

Browse files
EvenxfBenjamin Tissoires
authored andcommitted
HID: Intel-thc-hid: Intel-thc: Add safety check for reading DMA buffer
Add DMA buffer readiness check before reading DMA buffer to avoid unexpected NULL pointer accessing. Signed-off-by: Even Xu <even.xu@intel.com> Tested-by: Rui Zhang <rui1.zhang@intel.com> Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
1 parent dd76788 commit a9a9179

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -575,6 +575,11 @@ static int read_dma_buffer(struct thc_device *dev,
575575
return -EINVAL;
576576
}
577577

578+
if (!read_config->prd_tbls || !read_config->sgls[prd_table_index]) {
579+
dev_err_once(dev->dev, "PRD tables are not ready yet\n");
580+
return -EINVAL;
581+
}
582+
578583
prd_tbl = &read_config->prd_tbls[prd_table_index];
579584
mes_len = calc_message_len(prd_tbl, &nent);
580585
if (mes_len > read_config->max_packet_size) {

0 commit comments

Comments
 (0)