Skip to content

Commit a69ae32

Browse files
andy-shevgroeck
authored andcommitted
hwmon: (pmbus/tps25990) Don't check for specific errors when parsing properties
Instead of checking for the specific error codes (that can be considered a layering violation to some extent) check for the property existence first and then either parse it, or apply a default value. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20260219141936.2259945-1-andriy.shevchenko@linux.intel.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent ff708b5 commit a69ae32

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

drivers/hwmon/pmbus/tps25990.c

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -402,12 +402,18 @@ static int tps25990_probe(struct i2c_client *client)
402402
{
403403
struct device *dev = &client->dev;
404404
struct pmbus_driver_info *info;
405-
u32 rimon = TPS25990_DEFAULT_RIMON;
405+
const char *propname;
406+
u32 rimon;
406407
int ret;
407408

408-
ret = device_property_read_u32(dev, "ti,rimon-micro-ohms", &rimon);
409-
if (ret < 0 && ret != -EINVAL)
410-
return dev_err_probe(dev, ret, "failed to get rimon\n");
409+
propname = "ti,rimon-micro-ohms";
410+
if (device_property_present(dev, propname)) {
411+
ret = device_property_read_u32(dev, propname, &rimon);
412+
if (ret)
413+
return dev_err_probe(dev, ret, "failed to get %s\n", propname);
414+
} else {
415+
rimon = TPS25990_DEFAULT_RIMON;
416+
}
411417

412418
info = devm_kmemdup(dev, &tps25990_base_info, sizeof(*info), GFP_KERNEL);
413419
if (!info)

0 commit comments

Comments
 (0)