Skip to content

Commit a5a1b46

Browse files
crystalstorm466gregkh
authored andcommitted
staging: rtl8723bs: rename variables to snake_case
The Linux kernel coding style guidelines prohibit the use of CamelCase variable names. All variables should be snakecase. Rename the 'ChipVersion' parameter to 'chip_version' and the 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to the standard snakecase naming convention. Signed-off-by: David Holland <david@cardinalsystem.net> Link: https://patch.msgid.link/20260327203636.24891-1-david@cardinalsystem.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d915dde commit a5a1b46

1 file changed

Lines changed: 19 additions & 19 deletions

File tree

drivers/staging/rtl8723bs/hal/hal_com.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -31,44 +31,44 @@ void rtw_hal_data_deinit(struct adapter *padapter)
3131
}
3232

3333

34-
void dump_chip_info(struct hal_version ChipVersion)
34+
void dump_chip_info(struct hal_version chip_version)
3535
{
3636
char buf[128];
3737
size_t cnt = 0;
3838

3939
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "Chip Version Info: CHIP_8723B_%s_",
40-
IS_NORMAL_CHIP(ChipVersion) ? "Normal_Chip" : "Test_Chip");
40+
IS_NORMAL_CHIP(chip_version) ? "Normal_Chip" : "Test_Chip");
4141

42-
if (IS_CHIP_VENDOR_TSMC(ChipVersion))
42+
if (IS_CHIP_VENDOR_TSMC(chip_version))
4343
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "TSMC_");
44-
else if (IS_CHIP_VENDOR_UMC(ChipVersion))
44+
else if (IS_CHIP_VENDOR_UMC(chip_version))
4545
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "UMC_");
46-
else if (IS_CHIP_VENDOR_SMIC(ChipVersion))
46+
else if (IS_CHIP_VENDOR_SMIC(chip_version))
4747
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "SMIC_");
4848

49-
if (IS_A_CUT(ChipVersion))
49+
if (IS_A_CUT(chip_version))
5050
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "A_CUT_");
51-
else if (IS_B_CUT(ChipVersion))
51+
else if (IS_B_CUT(chip_version))
5252
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "B_CUT_");
53-
else if (IS_C_CUT(ChipVersion))
53+
else if (IS_C_CUT(chip_version))
5454
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "C_CUT_");
55-
else if (IS_D_CUT(ChipVersion))
55+
else if (IS_D_CUT(chip_version))
5656
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "D_CUT_");
57-
else if (IS_E_CUT(ChipVersion))
57+
else if (IS_E_CUT(chip_version))
5858
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "E_CUT_");
59-
else if (IS_I_CUT(ChipVersion))
59+
else if (IS_I_CUT(chip_version))
6060
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "I_CUT_");
61-
else if (IS_J_CUT(ChipVersion))
61+
else if (IS_J_CUT(chip_version))
6262
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "J_CUT_");
63-
else if (IS_K_CUT(ChipVersion))
63+
else if (IS_K_CUT(chip_version))
6464
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "K_CUT_");
6565
else
6666
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt,
67-
"UNKNOWN_CUT(%d)_", ChipVersion.CUTVersion);
67+
"UNKNOWN_CUT(%d)_", chip_version.CUTVersion);
6868

6969
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "1T1R_");
7070

71-
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVersion.ROMVer);
71+
cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", chip_version.ROMVer);
7272
}
7373

7474

@@ -86,7 +86,7 @@ void dump_chip_info(struct hal_version ChipVersion)
8686
* BIT[6:0] Channel Plan
8787
*sw_channel_plan channel plan from SW (registry/module param)
8888
*def_channel_plan channel plan used when HW/SW both invalid
89-
*AutoLoadFail efuse autoload fail or not
89+
*auto_load_fail efuse autoload fail or not
9090
*
9191
* Return:
9292
*Final channel plan decision
@@ -97,7 +97,7 @@ u8 hal_com_config_channel_plan(
9797
u8 hw_channel_plan,
9898
u8 sw_channel_plan,
9999
u8 def_channel_plan,
100-
bool AutoLoadFail
100+
bool auto_load_fail
101101
)
102102
{
103103
struct hal_com_data *pHalData;
@@ -108,9 +108,9 @@ u8 hal_com_config_channel_plan(
108108
chnlPlan = def_channel_plan;
109109

110110
if (0xFF == hw_channel_plan)
111-
AutoLoadFail = true;
111+
auto_load_fail = true;
112112

113-
if (!AutoLoadFail) {
113+
if (!auto_load_fail) {
114114
u8 hw_chnlPlan;
115115

116116
hw_chnlPlan = hw_channel_plan & (~EEPROM_CHANNEL_PLAN_BY_HW_MASK);

0 commit comments

Comments
 (0)