Skip to content

Commit a2753f0

Browse files
Shubzz-02lag-linaro
authored andcommitted
mfd: dln2: Switch to managed resources and fix bare unsigned types
Convert dln2_probe and dln2_setup_rx_urbs to use devm_kzalloc() and devm_kmalloc() respectively. This simplifies resource management by allowing the removal of manual kfree() calls in dln2_free() and dln2_free_rx_urbs(). Additionally, update bare 'unsigned' types to 'unsigned int' to satisfy checkpatch.pl warnings and comply with the Linux kernel coding style. Signed-off-by: Subhash Rawat <rawatsubhash02@gmail.com> Link: https://patch.msgid.link/20260303183236.574940-1-rawatsubhash02@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 9abc081 commit a2753f0

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

drivers/mfd/dln2.c

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -424,8 +424,8 @@ static void free_rx_slot(struct dln2_dev *dln2, u16 handle, int slot)
424424
}
425425

426426
static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
427-
const void *obuf, unsigned obuf_len,
428-
void *ibuf, unsigned *ibuf_len)
427+
const void *obuf, unsigned int obuf_len,
428+
void *ibuf, unsigned int *ibuf_len)
429429
{
430430
int ret = 0;
431431
int rx_slot;
@@ -511,8 +511,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
511511
}
512512

513513
int dln2_transfer(struct platform_device *pdev, u16 cmd,
514-
const void *obuf, unsigned obuf_len,
515-
void *ibuf, unsigned *ibuf_len)
514+
const void *obuf, unsigned int obuf_len,
515+
void *ibuf, unsigned int *ibuf_len)
516516
{
517517
struct dln2_platform_data *dln2_pdata;
518518
struct dln2_dev *dln2;
@@ -583,10 +583,8 @@ static void dln2_free_rx_urbs(struct dln2_dev *dln2)
583583
{
584584
int i;
585585

586-
for (i = 0; i < DLN2_MAX_URBS; i++) {
586+
for (i = 0; i < DLN2_MAX_URBS; i++)
587587
usb_free_urb(dln2->rx_urb[i]);
588-
kfree(dln2->rx_buf[i]);
589-
}
590588
}
591589

592590
static void dln2_stop_rx_urbs(struct dln2_dev *dln2)
@@ -600,17 +598,17 @@ static void dln2_stop_rx_urbs(struct dln2_dev *dln2)
600598
static void dln2_free(struct dln2_dev *dln2)
601599
{
602600
dln2_free_rx_urbs(dln2);
603-
kfree(dln2);
604601
}
605602

606603
static int dln2_setup_rx_urbs(struct dln2_dev *dln2,
607604
struct usb_host_interface *hostif)
608605
{
609606
int i;
610607
const int rx_max_size = DLN2_RX_BUF_SIZE;
608+
struct device *dev = &dln2->interface->dev;
611609

612610
for (i = 0; i < DLN2_MAX_URBS; i++) {
613-
dln2->rx_buf[i] = kmalloc(rx_max_size, GFP_KERNEL);
611+
dln2->rx_buf[i] = devm_kmalloc(dev, rx_max_size, GFP_KERNEL);
614612
if (!dln2->rx_buf[i])
615613
return -ENOMEM;
616614

@@ -777,7 +775,7 @@ static int dln2_probe(struct usb_interface *interface,
777775
if (ret)
778776
return ret;
779777

780-
dln2 = kzalloc_obj(*dln2);
778+
dln2 = devm_kzalloc(dev, sizeof(*dln2), GFP_KERNEL);
781779
if (!dln2)
782780
return -ENOMEM;
783781

0 commit comments

Comments
 (0)