Skip to content

Commit a175ee8

Browse files
tobluxaxboe
authored andcommitted
block: use sysfs_emit in sysfs show functions
Replace sprintf() with sysfs_emit() in sysfs show functions. sysfs_emit() is preferred for formatting sysfs output because it provides safer bounds checking. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Link: https://patch.msgid.link/20260402164958.894879-4-thorsten.blum@linux.dev Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 4e56428 commit a175ee8

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

block/partitions/core.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/major.h>
99
#include <linux/slab.h>
1010
#include <linux/string.h>
11+
#include <linux/sysfs.h>
1112
#include <linux/ctype.h>
1213
#include <linux/vmalloc.h>
1314
#include <linux/raid/detect.h>
@@ -177,31 +178,31 @@ static struct parsed_partitions *check_partition(struct gendisk *hd)
177178
static ssize_t part_partition_show(struct device *dev,
178179
struct device_attribute *attr, char *buf)
179180
{
180-
return sprintf(buf, "%d\n", bdev_partno(dev_to_bdev(dev)));
181+
return sysfs_emit(buf, "%d\n", bdev_partno(dev_to_bdev(dev)));
181182
}
182183

183184
static ssize_t part_start_show(struct device *dev,
184185
struct device_attribute *attr, char *buf)
185186
{
186-
return sprintf(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect);
187+
return sysfs_emit(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect);
187188
}
188189

189190
static ssize_t part_ro_show(struct device *dev,
190191
struct device_attribute *attr, char *buf)
191192
{
192-
return sprintf(buf, "%d\n", bdev_read_only(dev_to_bdev(dev)));
193+
return sysfs_emit(buf, "%d\n", bdev_read_only(dev_to_bdev(dev)));
193194
}
194195

195196
static ssize_t part_alignment_offset_show(struct device *dev,
196197
struct device_attribute *attr, char *buf)
197198
{
198-
return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
199+
return sysfs_emit(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
199200
}
200201

201202
static ssize_t part_discard_alignment_show(struct device *dev,
202203
struct device_attribute *attr, char *buf)
203204
{
204-
return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
205+
return sysfs_emit(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
205206
}
206207

207208
static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);

0 commit comments

Comments
 (0)