Skip to content

Commit 97ab896

Browse files
Markus Mayernamhyung
authored andcommitted
perf build: fix "argument list too long" in second location
Turns out that displaying "RM $^" via quiet_cmd_rm can also upset the shell and cause it to display "argument list too long". Trying to quote $^ doesn't help. In the end, *not* displaying the (potentially long) list of files is probably the right thing to do for a "quiet" message, anyway. Instead, let's display a count of how many files were removed. There is always V=1 if more detail is required. TEST linux/tools/perf/pmu-events/metric_test.log RM ...634 orphan file(s)... LD linux/tools/perf/util/perf-util-in.o Also move the comment regarding xargs before the rule, so it doesn't show up in the build output. Signed-off-by: Markus Mayer <mmayer@broadcom.com> Reviewed-by: James Clark <james.clark@linaro.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
1 parent dff56bd commit 97ab896

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • tools/perf/pmu-events

tools/perf/pmu-events/Build

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,10 @@ ifneq ($(strip $(ORPHAN_FILES)),)
211211

212212
# Message for $(call echo-cmd,rm). Generally cleaning files isn't part
213213
# of a build step.
214-
quiet_cmd_rm = RM $^
214+
quiet_cmd_rm = RM ...$(words $^) orphan file(s)...
215215

216+
# The list of files can be long. Use xargs to prevent issues.
216217
prune_orphans: $(ORPHAN_FILES)
217-
# The list of files can be long. Use xargs to prevent issues.
218218
$(Q)$(call echo-cmd,rm)echo "$^" | xargs rm -f
219219

220220
JEVENTS_DEPS += prune_orphans

0 commit comments

Comments
 (0)