Skip to content

Commit 9709b56

Browse files
AKoskovichPaolo Abeni
authored andcommitted
net: ipa: fix GENERIC_CMD register field masks for IPA v5.0+
Fix the field masks to match the hardware layout documented in downstream GSI (GSI_V3_0_EE_n_GSI_EE_GENERIC_CMD_*). Notably this fixes a WARN I was seeing when I tried to send "stop" to the MPSS remoteproc while IPA was up. Fixes: faf0678 ("net: ipa: add IPA v5.0 GSI register definitions") Signed-off-by: Alexander Koskovich <akoskovich@pm.me> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20260403-milos-ipa-v1-1-01e9e4e03d3e@fairphone.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 2607c09 commit 9709b56

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/net/ipa/reg/gsi_reg-v5.0.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,10 @@ REG_FIELDS(EV_CH_CMD, ev_ch_cmd, 0x00025010 + 0x12000 * GSI_EE_AP);
156156

157157
static const u32 reg_generic_cmd_fmask[] = {
158158
[GENERIC_OPCODE] = GENMASK(4, 0),
159-
[GENERIC_CHID] = GENMASK(9, 5),
160-
[GENERIC_EE] = GENMASK(13, 10),
161-
/* Bits 14-31 reserved */
159+
[GENERIC_CHID] = GENMASK(12, 5),
160+
[GENERIC_EE] = GENMASK(16, 13),
161+
/* Bits 17-23 reserved */
162+
[GENERIC_PARAMS] = GENMASK(31, 24),
162163
};
163164

164165
REG_FIELDS(GENERIC_CMD, generic_cmd, 0x00025018 + 0x12000 * GSI_EE_AP);

0 commit comments

Comments
 (0)