Skip to content

Commit 91dc0c2

Browse files
dtorlag-linaro
authored andcommitted
leds: core: Fix formatting issues
Fix formatting issues reported by checkpatch.pl, such as extra empty lines, lack of braces on some branches, and misaligned function arguments. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Link: https://patch.msgid.link/20260311-led-swnode-name-v1-2-798a49e041c6@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 4f530c6 commit 91dc0c2

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

drivers/leds/led-core.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static void led_timer_function(struct timer_list *t)
8585
if (!brightness) {
8686
/* Time to switch the LED on. */
8787
if (test_and_clear_bit(LED_BLINK_BRIGHTNESS_CHANGE,
88-
&led_cdev->work_flags))
88+
&led_cdev->work_flags))
8989
brightness = led_cdev->new_blink_brightness;
9090
else
9191
brightness = led_cdev->blink_brightness;
@@ -217,10 +217,9 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
217217
mod_timer(&led_cdev->blink_timer, jiffies + 1);
218218
}
219219

220-
221220
static void led_blink_setup(struct led_classdev *led_cdev,
222-
unsigned long *delay_on,
223-
unsigned long *delay_off)
221+
unsigned long *delay_on,
222+
unsigned long *delay_off)
224223
{
225224
if (!test_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags) &&
226225
led_cdev->blink_set &&
@@ -262,7 +261,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev,
262261
int invert)
263262
{
264263
if (test_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags) &&
265-
timer_pending(&led_cdev->blink_timer))
264+
timer_pending(&led_cdev->blink_timer))
266265
return;
267266

268267
set_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags);
@@ -347,9 +346,9 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev, unsigned int value)
347346
/* Ensure delayed_set_value is seen before work_flags modification */
348347
smp_mb__before_atomic();
349348

350-
if (value)
349+
if (value) {
351350
set_bit(LED_SET_BRIGHTNESS, &led_cdev->work_flags);
352-
else {
351+
} else {
353352
clear_bit(LED_SET_BRIGHTNESS, &led_cdev->work_flags);
354353
clear_bit(LED_SET_BLINK, &led_cdev->work_flags);
355354
set_bit(LED_SET_BRIGHTNESS_OFF, &led_cdev->work_flags);
@@ -499,7 +498,6 @@ static void led_parse_fwnode_props(struct device *dev,
499498
props->color_present = true;
500499
}
501500

502-
503501
if (!fwnode_property_present(fwnode, "function"))
504502
return;
505503

@@ -584,8 +582,9 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,
584582
} else if (is_software_node(fwnode)) {
585583
n = snprintf(led_classdev_name, LED_MAX_NAME_SIZE, "%s",
586584
fwnode_get_name(fwnode));
587-
} else
585+
} else {
588586
return -EINVAL;
587+
}
589588

590589
if (n >= LED_MAX_NAME_SIZE)
591590
return -E2BIG;

0 commit comments

Comments
 (0)