Skip to content

Commit 8bbde98

Browse files
sjp38akpm00
authored andcommitted
mm/damon/core: disallow time-quota setting zero esz
When the throughput of a DAMOS scheme is very slow, DAMOS time quota can make the effective size quota smaller than damon_ctx->min_region_sz. In the case, damos_apply_scheme() will skip applying the action, because the action is tried at region level, which requires >=min_region_sz size. That is, the quota is effectively exceeded for the quota charge window. Because no action will be applied, the total_charged_sz and total_charged_ns are also not updated. damos_set_effective_quota() will try to update the effective size quota before starting the next charge window. However, because the total_charged_sz and total_charged_ns have not updated, the throughput and effective size quota are also not changed. Since effective size quota can only be decreased, other effective size quota update factors including DAMOS quota goals and size quota cannot make any change, either. As a result, the scheme is unexpectedly deactivated until the user notices and mitigates the situation. The users can mitigate this situation by changing the time quota online or re-install the scheme. While the mitigation is somewhat straightforward, finding the situation would be challenging, because DAMON is not providing good observabilities for that. Even if such observability is provided, doing the additional monitoring and the mitigation is somewhat cumbersome and not aligned to the intention of the time quota. The time quota was intended to help reduce the user's administration overhead. Fix the problem by setting time quota-modified effective size quota be at least min_region_sz always. The issue was discovered [1] by sashiko. Link: https://lore.kernel.org/20260407003153.79589-1-sj@kernel.org Link: https://lore.kernel.org/20260405192504.110014-1-sj@kernel.org [1] Fixes: 1cd2430 ("mm/damon/schemes: implement time quota") Signed-off-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> # 5.16.x Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 8fedac3 commit 8bbde98

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

mm/damon/core.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2228,7 +2228,8 @@ static unsigned long damos_quota_score(struct damos_quota *quota)
22282228
/*
22292229
* Called only if quota->ms, or quota->sz are set, or quota->goals is not empty
22302230
*/
2231-
static void damos_set_effective_quota(struct damos_quota *quota)
2231+
static void damos_set_effective_quota(struct damos_quota *quota,
2232+
struct damon_ctx *ctx)
22322233
{
22332234
unsigned long throughput;
22342235
unsigned long esz = ULONG_MAX;
@@ -2254,6 +2255,7 @@ static void damos_set_effective_quota(struct damos_quota *quota)
22542255
else
22552256
throughput = PAGE_SIZE * 1024;
22562257
esz = min(throughput * quota->ms, esz);
2258+
esz = max(ctx->min_region_sz, esz);
22572259
}
22582260

22592261
if (quota->sz && quota->sz < esz)
@@ -2290,7 +2292,7 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s)
22902292
/* First charge window */
22912293
if (!quota->total_charged_sz && !quota->charged_from) {
22922294
quota->charged_from = jiffies;
2293-
damos_set_effective_quota(quota);
2295+
damos_set_effective_quota(quota, c);
22942296
}
22952297

22962298
/* New charge window starts */
@@ -2303,7 +2305,7 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s)
23032305
quota->charged_sz = 0;
23042306
if (trace_damos_esz_enabled())
23052307
cached_esz = quota->esz;
2306-
damos_set_effective_quota(quota);
2308+
damos_set_effective_quota(quota, c);
23072309
if (trace_damos_esz_enabled() && quota->esz != cached_esz)
23082310
damos_trace_esz(c, s, quota);
23092311
}

0 commit comments

Comments
 (0)