Skip to content

Commit 88cc4cb

Browse files
fschnyderbjorn-helgaas
authored andcommitted
PCI: imx6: Fix reference clock source selection for i.MX95
In the PCIe PHY init for the i.MX95, the reference clock source selection uses a conditional instead of always passing the mask. This currently breaks functionality if the internal refclk is used. To fix this issue, always pass IMX95_PCIE_REF_USE_PAD as the mask and clear bit if external refclk is not used. This essentially swaps the parameters. Fixes: d8574ce ("PCI: imx6: Add external reference clock input mode support") Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Richard Zhu <hongxing.zhu@nxp.com> Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260325093118.684142-1-fra.schnyder@gmail.com
1 parent 3a4e830 commit 88cc4cb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/pci/controller/dwc/pci-imx6.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,8 @@ static int imx95_pcie_init_phy(struct imx_pcie *imx_pcie)
270270
IMX95_PCIE_PHY_CR_PARA_SEL);
271271

272272
regmap_update_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_PHY_GEN_CTRL,
273-
ext ? IMX95_PCIE_REF_USE_PAD : 0,
274-
IMX95_PCIE_REF_USE_PAD);
273+
IMX95_PCIE_REF_USE_PAD,
274+
ext ? IMX95_PCIE_REF_USE_PAD : 0);
275275
regmap_update_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_SS_RW_REG_0,
276276
IMX95_PCIE_REF_CLKEN,
277277
ext ? 0 : IMX95_PCIE_REF_CLKEN);

0 commit comments

Comments
 (0)