Skip to content

Commit 8765715

Browse files
Kuppuswamy Sathyanarayananrafaeljw
authored andcommitted
powercap: intel_rapl: Remove unused AVERAGE_POWER primitive
The AVERAGE_POWER primitive and RAPL_PRIMITIVE_DERIVED flag are not used anywhere in the code. Remove them to simplify the primitive handling logic. No functional changes. Co-developed-by: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://patch.msgid.link/20260313185333.2370733-2-sathyanarayanan.kuppuswamy@linux.intel.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent f3b5368 commit 8765715

2 files changed

Lines changed: 0 additions & 14 deletions

File tree

drivers/powercap/intel_rapl_common.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@
9090
#define TPMI_INFO_MAX_TIME_WIN_MASK GENMASK_ULL(60, 54)
9191

9292
/* Non HW constants */
93-
#define RAPL_PRIMITIVE_DERIVED BIT(1) /* not from raw data */
9493
#define RAPL_PRIMITIVE_DUMMY BIT(2)
9594

9695
#define ENERGY_UNIT_SCALE 1000 /* scale from driver unit to powercap unit */
@@ -703,9 +702,6 @@ static struct rapl_primitive_info rpi_msr[NR_RAPL_PRIMITIVES] = {
703702
19, RAPL_DOMAIN_REG_LIMIT, TIME_UNIT, 0),
704703
[PSYS_TIME_WINDOW2] = PRIMITIVE_INFO_INIT(PSYS_TIME_WINDOW2, PSYS_TIME_WINDOW2_MASK,
705704
51, RAPL_DOMAIN_REG_LIMIT, TIME_UNIT, 0),
706-
/* non-hardware */
707-
[AVERAGE_POWER] = PRIMITIVE_INFO_INIT(AVERAGE_POWER, 0, 0, 0, POWER_UNIT,
708-
RAPL_PRIMITIVE_DERIVED),
709705
};
710706

711707
/* RAPL primitives for TPMI I/F */
@@ -745,9 +741,6 @@ static struct rapl_primitive_info rpi_tpmi[NR_RAPL_PRIMITIVES] = {
745741
54, RAPL_DOMAIN_REG_INFO, TIME_UNIT, 0),
746742
[THROTTLED_TIME] = PRIMITIVE_INFO_INIT(THROTTLED_TIME, PERF_STATUS_THROTTLE_TIME_MASK,
747743
0, RAPL_DOMAIN_REG_PERF, TIME_UNIT, 0),
748-
/* non-hardware */
749-
[AVERAGE_POWER] = PRIMITIVE_INFO_INIT(AVERAGE_POWER, 0, 0, 0, POWER_UNIT,
750-
RAPL_PRIMITIVE_DERIVED),
751744
};
752745

753746
static struct rapl_primitive_info *get_rpi(struct rapl_package *rp, int prim)
@@ -841,12 +834,6 @@ static int rapl_read_data_raw(struct rapl_domain *rd,
841834
if (!ra.reg.val)
842835
return -EINVAL;
843836

844-
/* non-hardware data are collected by the polling thread */
845-
if (rpi->flag & RAPL_PRIMITIVE_DERIVED) {
846-
*data = rd->rdd.primitives[prim];
847-
return 0;
848-
}
849-
850837
ra.mask = rpi->mask;
851838

852839
if (rd->rp->priv->read_raw(get_rid(rd->rp), &ra, pmu_ctx)) {

include/linux/intel_rapl.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ enum rapl_primitives {
7777
PSYS_TIME_WINDOW1,
7878
PSYS_TIME_WINDOW2,
7979
/* below are not raw primitive data */
80-
AVERAGE_POWER,
8180
NR_RAPL_PRIMITIVES,
8281
};
8382

0 commit comments

Comments
 (0)