Skip to content

Commit 8708194

Browse files
hodgesdsmimizohar
authored andcommitted
ima: check return value of crypto_shash_final() in boot aggregate
The return value of crypto_shash_final() is not checked in ima_calc_boot_aggregate_tfm(). If the hash finalization fails, the function returns success and a corrupted boot aggregate digest could be used for IMA measurements. Capture the return value and propagate any error to the caller. Fixes: 76bb28f ("ima: use new crypto_shash API instead of old crypto_hash") Signed-off-by: Daniel Hodges <hodgesd@meta.com> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
1 parent a74d719 commit 8708194

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

security/integrity/ima/ima_crypto.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,7 @@ static int ima_calc_boot_aggregate_tfm(char *digest, u16 alg_id,
838838
}
839839
}
840840
if (!rc)
841-
crypto_shash_final(shash, digest);
841+
rc = crypto_shash_final(shash, digest);
842842
return rc;
843843
}
844844

0 commit comments

Comments
 (0)