Skip to content

Commit 81fca70

Browse files
rbmarliererostedt
authored andcommitted
ktest: Store failure logs also in fatal paths
STORE_FAILURES was only saved from fail(), so paths that reached dodie() could exit without preserving failure logs. That includes fatal hook paths such as: POST_BUILD_DIE = 1 and ordinary failures when: DIE_ON_FAILURE = 1 Call save_logs("fail", ...) from dodie() too so fatal failures keep the same STORE_FAILURES artifacts as non-fatal fail() paths. Cc: John Hawley <warthog9@eaglescrag.net> Link: https://patch.msgid.link/20260318-ktest-fixes-v1-1-9dd94d46d84c@suse.com Signed-off-by: Ricardo B. Marlière <rbm@suse.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent 2295174 commit 81fca70

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

tools/testing/ktest/ktest.pl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,6 +1635,11 @@ sub dodie {
16351635
print " See $opt{LOG_FILE} for more info.\n";
16361636
}
16371637

1638+
# Fatal paths bypass fail(), so STORE_FAILURES needs to be handled here.
1639+
if (defined($store_failures)) {
1640+
save_logs("fail", $store_failures);
1641+
}
1642+
16381643
if ($email_on_error) {
16391644
my $name = get_test_name;
16401645
my $log_file;

0 commit comments

Comments
 (0)