Skip to content

Commit 801ca4c

Browse files
author
Alex Williamson
committed
vfio/platform: Mark reset drivers for removal
While vfio-platform itself is on a reprieve from being removed[1], these reset drivers don't support any current hardware, are not being tested, and suggest a level of support that doesn't really exist. Mark them for removal to surface any remaining user such that we can potentially drop them and simplify the code if none appear. Link: https://lore.kernel.org/all/20250806170314.3768750-3-alex.williamson@redhat.com [1] Reviewed-by: Pranjal Shrivastava <praan@google.com> Reviewed-by: Mostafa Saleh <smostafa@google.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Link: https://lore.kernel.org/r/20250825175807.3264083-3-alex.williamson@redhat.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
1 parent fd0f753 commit 801ca4c

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

drivers/vfio/platform/reset/Kconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22
if VFIO_PLATFORM
33
config VFIO_PLATFORM_CALXEDAXGMAC_RESET
4-
tristate "VFIO support for calxeda xgmac reset"
4+
tristate "VFIO support for calxeda xgmac reset (DEPRECATED)"
55
help
66
Enables the VFIO platform driver to handle reset for Calxeda xgmac
77

88
If you don't know what to do here, say N.
99

1010
config VFIO_PLATFORM_AMDXGBE_RESET
11-
tristate "VFIO support for AMD XGBE reset"
11+
tristate "VFIO support for AMD XGBE reset (DEPRECATED)"
1212
help
1313
Enables the VFIO platform driver to handle reset for AMD XGBE
1414

1515
If you don't know what to do here, say N.
1616

1717
config VFIO_PLATFORM_BCMFLEXRM_RESET
18-
tristate "VFIO support for Broadcom FlexRM reset"
18+
tristate "VFIO support for Broadcom FlexRM reset (DEPRECATED)"
1919
depends on ARCH_BCM_IPROC || COMPILE_TEST
2020
default ARCH_BCM_IPROC
2121
help

drivers/vfio/platform/reset/vfio_platform_amdxgbe.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
5252
u32 dma_mr_value, pcs_value, value;
5353
unsigned int count;
5454

55+
dev_err_once(vdev->device, "DEPRECATION: VFIO AMD XGBE platform reset is deprecated and will be removed in a future kernel release\n");
56+
5557
if (!xgmac_regs->ioaddr) {
5658
xgmac_regs->ioaddr =
5759
ioremap(xgmac_regs->addr, xgmac_regs->size);

drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ static int vfio_platform_bcmflexrm_reset(struct vfio_platform_device *vdev)
7272
int rc = 0, ret = 0, ring_num = 0;
7373
struct vfio_platform_region *reg = &vdev->regions[0];
7474

75+
dev_err_once(vdev->device, "DEPRECATION: VFIO Broadcom FlexRM platform reset is deprecated and will be removed in a future kernel release\n");
76+
7577
/* Map FlexRM ring registers if not mapped */
7678
if (!reg->ioaddr) {
7779
reg->ioaddr = ioremap(reg->addr, reg->size);

drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ static int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)
5050
{
5151
struct vfio_platform_region *reg = &vdev->regions[0];
5252

53+
dev_err_once(vdev->device, "DEPRECATION: VFIO Calxeda xgmac platform reset is deprecated and will be removed in a future kernel release\n");
54+
5355
if (!reg->ioaddr) {
5456
reg->ioaddr =
5557
ioremap(reg->addr, reg->size);

0 commit comments

Comments
 (0)