Skip to content

Commit 7f0fc00

Browse files
DispatchCodealexdeucher
authored andcommitted
drm/amdgpu: replace use of system_unbound_wq with system_dfl_wq
This patch continues the effort to refactor workqueue APIs, which has begun with the changes introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") The point of the refactoring is to eventually alter the default behavior of workqueues to become unbound by default so that their workload placement is optimized by the scheduler. Before that to happen after a careful review and conversion of each individual case, workqueue users must be converted to the better named new workqueues with no intended behaviour changes: system_wq -> system_percpu_wq system_unbound_wq -> system_dfl_wq This way the old obsolete workqueues (system_wq, system_unbound_wq) can be removed in the future. Suggested-by: Tejun Heo <tj@kernel.org> Acked-by: Christian König <christian.koenig@amd.com> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 3ecee20 commit 7f0fc00

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/amd/amdgpu/aldebaran.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ aldebaran_mode2_perform_reset(struct amdgpu_reset_control *reset_ctl,
179179
list_for_each_entry(tmp_adev, reset_device_list, reset_list) {
180180
/* For XGMI run all resets in parallel to speed up the process */
181181
if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) {
182-
if (!queue_work(system_unbound_wq,
182+
if (!queue_work(system_dfl_wq,
183183
&tmp_adev->reset_cntl->reset_work))
184184
r = -EALREADY;
185185
} else

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5339,7 +5339,7 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
53395339
list_for_each_entry(tmp_adev, device_list_handle, reset_list) {
53405340
/* For XGMI run all resets in parallel to speed up the process */
53415341
if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) {
5342-
if (!queue_work(system_unbound_wq,
5342+
if (!queue_work(system_dfl_wq,
53435343
&tmp_adev->xgmi_reset_work))
53445344
r = -EALREADY;
53455345
} else

drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ static int amdgpu_reset_xgmi_reset_on_init_perform_reset(
116116
/* Mode1 reset needs to be triggered on all devices together */
117117
list_for_each_entry(tmp_adev, reset_device_list, reset_list) {
118118
/* For XGMI run all resets in parallel to speed up the process */
119-
if (!queue_work(system_unbound_wq, &tmp_adev->xgmi_reset_work))
119+
if (!queue_work(system_dfl_wq, &tmp_adev->xgmi_reset_work))
120120
r = -EALREADY;
121121
if (r) {
122122
dev_err(tmp_adev->dev,

0 commit comments

Comments
 (0)