Skip to content

Commit 7bf6ddc

Browse files
hkallweitfloatious
authored andcommitted
ata: libata-transport: remove static variable ata_scsi_transport_template
Simplify the code by making struct ata_scsi_transportt public, instead of using separate variable ata_scsi_transport_template. Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: Niklas Cassel <cassel@kernel.org>
1 parent 359942b commit 7bf6ddc

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

drivers/ata/libata-scsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4624,7 +4624,7 @@ int ata_scsi_add_hosts(struct ata_host *host, const struct scsi_host_template *s
46244624
*(struct ata_port **)&shost->hostdata[0] = ap;
46254625
ap->scsi_host = shost;
46264626

4627-
shost->transportt = ata_scsi_transport_template;
4627+
shost->transportt = &ata_scsi_transportt;
46284628
shost->unique_id = ap->print_id;
46294629
shost->max_id = 16;
46304630
shost->max_lun = 1;

drivers/ata/libata-transport.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
#include "libata.h"
3838
#include "libata-transport.h"
3939

40-
struct scsi_transport_template;
41-
struct scsi_transport_template *ata_scsi_transport_template;
42-
4340
static int ata_tlink_match(struct attribute_container *cont,
4441
struct device *dev);
4542
static int ata_tdev_match(struct attribute_container *cont,
@@ -224,7 +221,7 @@ static int ata_tport_match(struct attribute_container *cont,
224221
{
225222
if (!ata_is_port(dev))
226223
return 0;
227-
return &ata_scsi_transport_template->host_attrs.ac == cont;
224+
return &ata_scsi_transportt.host_attrs.ac == cont;
228225
}
229226

230227
/**
@@ -722,7 +719,7 @@ int ata_tlink_add(struct ata_link *link)
722719
return error;
723720
}
724721

725-
static struct scsi_transport_template ata_scsi_transportt = {
722+
struct scsi_transport_template ata_scsi_transportt = {
726723
.eh_strategy_handler = ata_scsi_error,
727724
.user_scan = ata_scsi_user_scan,
728725

@@ -783,8 +780,6 @@ __init int libata_transport_init(void)
783780
transport_container_register(&ata_link_attr_cont);
784781
transport_container_register(&ata_dev_attr_cont);
785782

786-
ata_scsi_transport_template = &ata_scsi_transportt;
787-
788783
return 0;
789784

790785
out_unregister_port:

drivers/ata/libata-transport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#define _LIBATA_TRANSPORT_H
44

55

6-
extern struct scsi_transport_template *ata_scsi_transport_template;
6+
extern struct scsi_transport_template ata_scsi_transportt;
77

88
int ata_tlink_add(struct ata_link *link);
99
void ata_tlink_delete(struct ata_link *link);

0 commit comments

Comments
 (0)