Skip to content

Commit 7bc4c8f

Browse files
jhovoldWolfram Sang
authored andcommitted
i2c: robotfuzz-osif: drop redundant device reference
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
1 parent 1f318b9 commit 7bc4c8f

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/i2c/busses/i2c-robotfuzz-osif.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static int osif_probe(struct usb_interface *interface,
141141
if (!priv)
142142
return -ENOMEM;
143143

144-
priv->usb_dev = usb_get_dev(interface_to_usbdev(interface));
144+
priv->usb_dev = interface_to_usbdev(interface);
145145
priv->interface = interface;
146146

147147
usb_set_intfdata(interface, priv);
@@ -163,7 +163,6 @@ static int osif_probe(struct usb_interface *interface,
163163
NULL, 0);
164164
if (ret) {
165165
dev_err(&interface->dev, "failure sending bit rate");
166-
usb_put_dev(priv->usb_dev);
167166
return ret;
168167
}
169168

@@ -184,7 +183,6 @@ static void osif_disconnect(struct usb_interface *interface)
184183

185184
i2c_del_adapter(&(priv->adapter));
186185
usb_set_intfdata(interface, NULL);
187-
usb_put_dev(priv->usb_dev);
188186
}
189187

190188
static struct usb_driver osif_driver = {

0 commit comments

Comments
 (0)