Skip to content

Commit 7a875c0

Browse files
oneukumgregkh
authored andcommitted
usb: yurex: fix race in probe
The bbu member of the descriptor must be set to the value standing for uninitialized values before the URB whose completion handler sets bbu is submitted. Otherwise there is a window during which probing can overwrite already retrieved data. Cc: stable <stable@kernel.org> Signed-off-by: Oliver Neukum <oneukum@suse.com> Link: https://patch.msgid.link/20260209143720.1507500-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0d6c814 commit 7a875c0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/usb/misc/yurex.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
272272
dev->int_buffer, YUREX_BUF_SIZE, yurex_interrupt,
273273
dev, 1);
274274
dev->urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
275+
dev->bbu = -1;
275276
if (usb_submit_urb(dev->urb, GFP_KERNEL)) {
276277
retval = -EIO;
277278
dev_err(&interface->dev, "Could not submitting URB\n");
@@ -280,7 +281,6 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
280281

281282
/* save our data pointer in this interface device */
282283
usb_set_intfdata(interface, dev);
283-
dev->bbu = -1;
284284

285285
/* we can register the device now, as it is ready */
286286
retval = usb_register_dev(interface, &yurex_class);

0 commit comments

Comments
 (0)