Skip to content

Commit 75d849c

Browse files
jhovoldbroonie
authored andcommitted
spi: syncuacer: fix controller deregistration
Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b0823ee ("spi: Add spi driver for Socionext SynQuacer platform") Cc: stable@vger.kernel.org # 5.3 Cc: Masahisa Kojima <masahisa.kojima@linaro.org> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260410081757.503099-21-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent d874a1c commit 75d849c

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

drivers/spi/spi-synquacer.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ static int synquacer_spi_probe(struct platform_device *pdev)
716716
pm_runtime_set_active(sspi->dev);
717717
pm_runtime_enable(sspi->dev);
718718

719-
ret = devm_spi_register_controller(sspi->dev, host);
719+
ret = spi_register_controller(host);
720720
if (ret)
721721
goto disable_pm;
722722

@@ -737,9 +737,15 @@ static void synquacer_spi_remove(struct platform_device *pdev)
737737
struct spi_controller *host = platform_get_drvdata(pdev);
738738
struct synquacer_spi *sspi = spi_controller_get_devdata(host);
739739

740+
spi_controller_get(host);
741+
742+
spi_unregister_controller(host);
743+
740744
pm_runtime_disable(sspi->dev);
741745

742746
clk_disable_unprepare(sspi->clk);
747+
748+
spi_controller_put(host);
743749
}
744750

745751
static int __maybe_unused synquacer_spi_suspend(struct device *dev)

0 commit comments

Comments
 (0)