accel/amdxdna: Fix incorrect error code returned for failed chain command

houlz0507 · houlz0507 · commit 750817a7c41d · 2026-02-03T11:35:53.000-08:00
The driver currently returns an incorrect error code when a chain command fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for failed chain commands. Fixes: aac2430 ("accel/amdxdna: Add command execution") Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org> Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> Link: https://patch.msgid.link/20260203184037.2751889-1-lizhi.hou@amd.com
diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
@@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
 		ret = -EINVAL;
 		goto out;
 	}
-	amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
+	amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
 
 	if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
 		struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void handle, void __iomem data, size_t size)`
`274`	`274`	`ret = -EINVAL;`
`275`	`275`	`goto out;`
`276`	`276`	`}`
`277`		`- amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);`
	`277`	`+ amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);`
`278`	`278`
`279`	`279`	`if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {`
`280`	`280`	`struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);`