Skip to content

Commit 734fd5b

Browse files
oneukumdtor
authored andcommitted
Input: pegasus_notetaker - use HID defines
The driver uses its own definitions for HID requests. This leads to duplication and obfuscation. Use HID's definitions. Signed-off-by: Oliver Neukum <oneukum@suse.com> Link: https://patch.msgid.link/20260325143256.371854-2-oneukum@suse.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent ffd01c3 commit 734fd5b

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/input/tablet/pegasus_notetaker.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
* T Tip
3737
*/
3838

39+
#include <linux/hid.h>
3940
#include <linux/kernel.h>
4041
#include <linux/module.h>
4142
#include <linux/input.h>
@@ -44,10 +45,6 @@
4445
#include <linux/workqueue.h>
4546
#include <linux/mutex.h>
4647

47-
/* USB HID defines */
48-
#define USB_REQ_GET_REPORT 0x01
49-
#define USB_REQ_SET_REPORT 0x09
50-
5148
#define USB_VENDOR_ID_PEGASUSTECH 0x0e20
5249
#define USB_DEVICE_ID_PEGASUS_NOTETAKER_EN100 0x0101
5350

@@ -108,7 +105,7 @@ static int pegasus_control_msg(struct pegasus *pegasus, u8 *data, int len)
108105

109106
result = usb_control_msg(pegasus->usbdev,
110107
usb_sndctrlpipe(pegasus->usbdev, 0),
111-
USB_REQ_SET_REPORT,
108+
HID_REQ_SET_REPORT,
112109
USB_TYPE_VENDOR | USB_DIR_OUT,
113110
0, 0, cmd_buf, sizeof_buf,
114111
USB_CTRL_SET_TIMEOUT);

0 commit comments

Comments
 (0)