Skip to content

Commit 707610b

Browse files
lgs2513hdeller
authored andcommitted
parisc: led: fix reference leak on failed device registration
When platform_device_register() fails in startup_leds(), the embedded struct device in platform_leds has already been initialized by device_initialize(), but the failure path only reports the error and does not drop the device reference for the current platform device: startup_leds() -> platform_device_register(&platform_leds) -> device_initialize(&platform_leds.dev) -> setup_pdev_dma_masks(&platform_leds) -> platform_device_add(&platform_leds) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() after reporting the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 789e527 ("parisc: led: Rewrite LED/LCD driver to utilizize Linux LED subsystem") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 1221365 commit 707610b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/parisc/led.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,10 @@ static void __init register_led_regions(void)
543543

544544
static int __init startup_leds(void)
545545
{
546-
if (platform_device_register(&platform_leds))
547-
printk(KERN_INFO "LED: failed to register LEDs\n");
546+
if (platform_device_register(&platform_leds)) {
547+
pr_info("LED: failed to register LEDs\n");
548+
platform_device_put(&platform_leds);
549+
}
548550
register_led_regions();
549551
return 0;
550552
}

0 commit comments

Comments
 (0)