Skip to content

Commit 70685c2

Browse files
Darrick J. Wongcmaiolino
authored andcommitted
xfs: don't irele after failing to iget in xfs_attri_recover_work
xlog_recovery_iget* never set @ip to a valid pointer if they return an error, so this irele will walk off a dangling pointer. Fix that. Cc: stable@vger.kernel.org # v6.10 Fixes: ae673f5 ("xfs: record inode generation in xattr update log intent items") Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Long Li <leo.lilong@huawei.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent c6c56ff commit 70685c2

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/xfs/xfs_attr_item.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,6 @@ xfs_attri_recover_work(
653653
break;
654654
}
655655
if (error) {
656-
xfs_irele(ip);
657656
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, attrp,
658657
sizeof(*attrp));
659658
return ERR_PTR(-EFSCORRUPTED);

0 commit comments

Comments
 (0)