Skip to content

Commit 6a5e3de

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix false alarm of lockdep on cp_global_sem lock
lockdep reported a potential deadlock: a) TCMU device removal context: - call del_gendisk() to get q->q_usage_counter - call start_flush_work() to get work_completion of wb->dwork b) f2fs writeback context: - in wb_workfn(), which holds work_completion of wb->dwork - call f2fs_balance_fs() to get sbi->gc_lock c) f2fs vfs_write context: - call f2fs_gc() to get sbi->gc_lock - call f2fs_write_checkpoint() to get sbi->cp_global_sem d) f2fs mount context: - call recover_fsync_data() to get sbi->cp_global_sem - call f2fs_check_and_fix_write_pointer() to call blkdev_report_zones() that goes down to blk_mq_alloc_request and get q->q_usage_counter Original callstack is in Closes tag. However, I think this is a false alarm due to before mount returns successfully (context d), we can not access file therein via vfs_write (context c). Let's introduce per-sb cp_global_sem_key, and assign the key for cp_global_sem, so that lockdep can recognize cp_global_sem from different super block correctly. A lot of work are done by Shin'ichiro Kawasaki, thanks a lot for the work. Fixes: c426d99 ("f2fs: Check write pointer consistency of open zones") Cc: stable@kernel.org Reported-and-tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Closes: https://lore.kernel.org/linux-f2fs-devel/20260218125237.3340441-1-shinichiro.kawasaki@wdc.com Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 238e14e commit 6a5e3de

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

fs/f2fs/f2fs.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2042,6 +2042,9 @@ struct f2fs_sb_info {
20422042
spinlock_t iostat_lat_lock;
20432043
struct iostat_lat_info *iostat_io_lat;
20442044
#endif
2045+
#ifdef CONFIG_DEBUG_LOCK_ALLOC
2046+
struct lock_class_key cp_global_sem_key;
2047+
#endif
20452048
};
20462049

20472050
/* Definitions to access f2fs_sb_info */

fs/f2fs/super.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4964,6 +4964,11 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
49644964
init_f2fs_rwsem_trace(&sbi->gc_lock, sbi, LOCK_NAME_GC_LOCK);
49654965
mutex_init(&sbi->writepages);
49664966
init_f2fs_rwsem_trace(&sbi->cp_global_sem, sbi, LOCK_NAME_CP_GLOBAL);
4967+
#ifdef CONFIG_DEBUG_LOCK_ALLOC
4968+
lockdep_register_key(&sbi->cp_global_sem_key);
4969+
lockdep_set_class(&sbi->cp_global_sem.internal_rwsem,
4970+
&sbi->cp_global_sem_key);
4971+
#endif
49674972
init_f2fs_rwsem_trace(&sbi->node_write, sbi, LOCK_NAME_NODE_WRITE);
49684973
init_f2fs_rwsem_trace(&sbi->node_change, sbi, LOCK_NAME_NODE_CHANGE);
49694974
spin_lock_init(&sbi->stat_lock);
@@ -5435,6 +5440,9 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
54355440
free_sb_buf:
54365441
kfree(raw_super);
54375442
free_sbi:
5443+
#ifdef CONFIG_DEBUG_LOCK_ALLOC
5444+
lockdep_unregister_key(&sbi->cp_global_sem_key);
5445+
#endif
54385446
kfree(sbi);
54395447
sb->s_fs_info = NULL;
54405448

@@ -5516,6 +5524,9 @@ static void kill_f2fs_super(struct super_block *sb)
55165524
/* Release block devices last, after fscrypt_destroy_keyring(). */
55175525
if (sbi) {
55185526
destroy_device_list(sbi);
5527+
#ifdef CONFIG_DEBUG_LOCK_ALLOC
5528+
lockdep_unregister_key(&sbi->cp_global_sem_key);
5529+
#endif
55195530
kfree(sbi);
55205531
sb->s_fs_info = NULL;
55215532
}

0 commit comments

Comments
 (0)