Skip to content

Commit 6895fc4

Browse files
jhovoldbroonie
authored andcommitted
spi: zynqmp-gqspi: fix controller deregistration
Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: dfe11a1 ("spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller") Cc: stable@vger.kernel.org # 4.2: 64640f6 Cc: stable@vger.kernel.org # 4.2 Cc: Ranjit Waghmode <ranjit.waghmode@xilinx.com> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260410081757.503099-26-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 0245435 commit 6895fc4

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/spi/spi-zynqmp-gqspi.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1324,7 +1324,7 @@ static int zynqmp_qspi_probe(struct platform_device *pdev)
13241324
ctlr->dev.of_node = np;
13251325
ctlr->auto_runtime_pm = true;
13261326

1327-
ret = devm_spi_register_controller(&pdev->dev, ctlr);
1327+
ret = spi_register_controller(ctlr);
13281328
if (ret) {
13291329
dev_err(&pdev->dev, "spi_register_controller failed\n");
13301330
goto clk_dis_all;
@@ -1362,6 +1362,8 @@ static void zynqmp_qspi_remove(struct platform_device *pdev)
13621362

13631363
pm_runtime_get_sync(&pdev->dev);
13641364

1365+
spi_unregister_controller(xqspi->ctlr);
1366+
13651367
zynqmp_gqspi_write(xqspi, GQSPI_EN_OFST, 0x0);
13661368

13671369
pm_runtime_disable(&pdev->dev);

0 commit comments

Comments
 (0)