Skip to content

Commit 665e064

Browse files
glneolag-linaro
authored andcommitted
leds: lp8860: Return directly from lp8860_init
No need to use goto to jump to a label that also just returns, return directly in the if statements. Signed-off-by: Andrew Davis <afd@ti.com> Link: https://patch.msgid.link/20260305203706.841384-2-afd@ti.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 4df6b6b commit 665e064

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

drivers/leds/leds-lp8860.c

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -216,41 +216,38 @@ static int lp8860_init(struct lp8860_led *led)
216216

217217
ret = lp8860_fault_check(led);
218218
if (ret)
219-
goto out;
219+
return ret;
220220

221221
ret = regmap_read(led->regmap, LP8860_STATUS, &read_buf);
222222
if (ret)
223-
goto out;
223+
return ret;
224224

225225
ret = lp8860_unlock_eeprom(led);
226226
if (ret) {
227227
dev_err(&led->client->dev, "Failed unlocking EEPROM\n");
228-
goto out;
228+
return ret;
229229
}
230230

231231
reg_count = ARRAY_SIZE(lp8860_eeprom_disp_regs);
232232
ret = regmap_multi_reg_write(led->regmap, lp8860_eeprom_disp_regs, reg_count);
233233
if (ret) {
234234
dev_err(&led->client->dev, "Failed writing EEPROM\n");
235-
goto out;
235+
return ret;
236236
}
237237

238238
ret = regmap_write(led->regmap, LP8860_EEPROM_UNLOCK, LP8860_LOCK_EEPROM);
239239
if (ret)
240-
goto out;
240+
return ret;
241241

242242
ret = regmap_write(led->regmap,
243243
LP8860_EEPROM_CNTRL,
244244
LP8860_PROGRAM_EEPROM);
245245
if (ret) {
246246
dev_err(&led->client->dev, "Failed programming EEPROM\n");
247-
goto out;
247+
return ret;
248248
}
249249

250-
return ret;
251-
252-
out:
253-
return ret;
250+
return 0;
254251
}
255252

256253
static const struct regmap_range lp8860_reg_ranges[] = {

0 commit comments

Comments
 (0)