Skip to content

Commit 653f310

Browse files
valpackettdtor
authored andcommitted
Input: goodix-berlin - report a resolution of 10 units/mm
Without a reported resolution, userspace was assuming 1 unit/mm which is wildly wrong: a regular smartphone is clearly not 2.4 meters tall. Most applications do not care much for this kind of raw mm value, but Phosh's on-screen keyboard would accidentally trigger swipe-to-close gestures due to misinterpreting small movements as huge ones. Do what the older goodix.c driver does and set the resolution to 10 units/mm to make sure the numbers calculated by userspace are reasonable. Signed-off-by: Val Packett <val@packett.cool> Link: https://patch.msgid.link/20260321073242.556253-1-val@packett.cool Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 79df764 commit 653f310

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/input/touchscreen/goodix_berlin_core.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -628,6 +628,14 @@ static int goodix_berlin_input_dev_config(struct goodix_berlin_core *cd,
628628

629629
touchscreen_parse_properties(cd->input_dev, true, &cd->props);
630630

631+
/*
632+
* The resolution of these touchscreens is about 10 units/mm, the actual
633+
* resolution does not matter much since we set INPUT_PROP_DIRECT.
634+
* Set it to 10 to ensure userspace isn't off by an order of magnitude.
635+
*/
636+
input_abs_set_res(cd->input_dev, ABS_MT_POSITION_X, 10);
637+
input_abs_set_res(cd->input_dev, ABS_MT_POSITION_Y, 10);
638+
631639
error = input_mt_init_slots(cd->input_dev, GOODIX_BERLIN_MAX_TOUCH,
632640
INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
633641
if (error)

0 commit comments

Comments
 (0)