Commit 65267c9
net: mana: Fix EQ leak in mana_remove on NULL port
In mana_remove(), when a NULL port is encountered in the port iteration
loop, 'goto out' skips the mana_destroy_eq(ac) call, leaking the event
queues allocated earlier by mana_create_eq().
This can happen when mana_probe_port() fails for port 0, leaving
ac->ports[0] as NULL. On driver unload or error cleanup, mana_remove()
hits the NULL entry and jumps past mana_destroy_eq().
Change 'goto out' to 'break' so the for-loop exits normally and
mana_destroy_eq() is always reached. Remove the now-unreferenced out:
label.
Fixes: 1e2d082 ("net: mana: Add support for EQ sharing")
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Link: https://patch.msgid.link/20260420124741.1056179-6-ernis@linux.microsoft.com
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>1 parent a7fdaf0 commit 65267c9
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3752 | 3752 | | |
3753 | 3753 | | |
3754 | 3754 | | |
3755 | | - | |
| 3755 | + | |
3756 | 3756 | | |
3757 | 3757 | | |
3758 | 3758 | | |
| |||
3783 | 3783 | | |
3784 | 3784 | | |
3785 | 3785 | | |
3786 | | - | |
| 3786 | + | |
3787 | 3787 | | |
3788 | 3788 | | |
3789 | 3789 | | |
| |||
0 commit comments