Skip to content

Commit 6363844

Browse files
tititiou36Andreas Hindborg
authored andcommitted
samples: configfs: Constify struct configfs_item_operations and configfs_group_operations
'struct configfs_item_operations' and 'configfs_group_operations' are not modified in this driver. Constifying these structures moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 7507 6504 64 14075 36fb samples/configfs/configfs_sample.o After: ===== text data bss dec hex filename 7827 6184 64 14075 36fb samples/configfs/configfs_sample.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/70c5fd68fcc4d3ba1f18002012fae19acf4ce50b.1767007414.git.christophe.jaillet@wanadoo.fr Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
1 parent 1d40cb0 commit 6363844

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

samples/configfs/configfs_sample.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ static void simple_child_release(struct config_item *item)
158158
kfree(to_simple_child(item));
159159
}
160160

161-
static struct configfs_item_operations simple_child_item_ops = {
161+
static const struct configfs_item_operations simple_child_item_ops = {
162162
.release = simple_child_release,
163163
};
164164

@@ -215,15 +215,15 @@ static void simple_children_release(struct config_item *item)
215215
kfree(to_simple_children(item));
216216
}
217217

218-
static struct configfs_item_operations simple_children_item_ops = {
218+
static const struct configfs_item_operations simple_children_item_ops = {
219219
.release = simple_children_release,
220220
};
221221

222222
/*
223223
* Note that, since no extra work is required on ->drop_item(),
224224
* no ->drop_item() is provided.
225225
*/
226-
static struct configfs_group_operations simple_children_group_ops = {
226+
static const struct configfs_group_operations simple_children_group_ops = {
227227
.make_item = simple_children_make_item,
228228
};
229229

@@ -292,7 +292,7 @@ static struct configfs_attribute *group_children_attrs[] = {
292292
* Note that, since no extra work is required on ->drop_item(),
293293
* no ->drop_item() is provided.
294294
*/
295-
static struct configfs_group_operations group_children_group_ops = {
295+
static const struct configfs_group_operations group_children_group_ops = {
296296
.make_group = group_children_make_group,
297297
};
298298

0 commit comments

Comments
 (0)