Skip to content

Commit 5d0efaf

Browse files
MrVanbroonie
authored andcommitted
regulator: pca9450: Correct interrupt type
Kernel warning on i.MX8MP-EVK when doing module test: irq: type mismatch, failed to map hwirq-3 for gpio@30200000! Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked interrupt bit status is changed and it is released high once application processor read INT1 register. So the interrupt should be configured as IRQF_TRIGGER_LOW, not IRQF_TRIGGER_FALLING. Fixes: 0935ff5 ("regulator: pca9450: add pca9450 pmic driver") Signed-off-by: Peng Fan <peng.fan@nxp.com> Link: https://patch.msgid.link/20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 1f318b9 commit 5d0efaf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/regulator/pca9450-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
13691369
if (pca9450->irq) {
13701370
ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
13711371
pca9450_irq_handler,
1372-
(IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
1372+
(IRQF_TRIGGER_LOW | IRQF_ONESHOT),
13731373
"pca9450-irq", pca9450);
13741374
if (ret != 0)
13751375
return dev_err_probe(pca9450->dev, ret, "Failed to request IRQ: %d\n",

0 commit comments

Comments
 (0)