Skip to content

Commit 5a8db80

Browse files
ruijieli51kuba-moo
authored andcommitted
net/smc: avoid early lgr access in smc_clc_wait_msg
A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group. The decline handling in smc_clc_wait_msg() updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged. This preserves the existing sync_err handling for established link-group contexts and avoids touching link-group state before it is available. Fixes: 0cfdd8f ("smc: connection and link group creation") Cc: stable@kernel.org Reported-by: Yuan Tan <yuantan098@gmail.com> Reported-by: Yifan Wu <yifanwucs@gmail.com> Reported-by: Juefei Pu <tomapufckgml@gmail.com> Reported-by: Xin Liu <bird@lzu.edu.cn> Signed-off-by: Ruijie Li <ruijieli51@gmail.com> Signed-off-by: Ren Wei <n05ec@lzu.edu.cn> Reviewed-by: Dust Li <dust.li@linux.alibaba.com> Link: https://patch.msgid.link/08c68a5c817acf198cce63d22517e232e8d60718.1776850759.git.ruijieli51@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 3d1f207 commit 5a8db80

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

net/smc/smc_clc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,8 +788,8 @@ int smc_clc_wait_msg(struct smc_sock *smc, void *buf, int buflen,
788788
dclc = (struct smc_clc_msg_decline *)clcm;
789789
reason_code = SMC_CLC_DECL_PEERDECL;
790790
smc->peer_diagnosis = ntohl(dclc->peer_diagnosis);
791-
if (((struct smc_clc_msg_decline *)buf)->hdr.typev2 &
792-
SMC_FIRST_CONTACT_MASK) {
791+
if ((dclc->hdr.typev2 & SMC_FIRST_CONTACT_MASK) &&
792+
smc->conn.lgr) {
793793
smc->conn.lgr->sync_err = 1;
794794
smc_lgr_terminate_sched(smc->conn.lgr);
795795
}

0 commit comments

Comments
 (0)