Skip to content

Commit 5a6a33b

Browse files
TomAi0jhovold
authored andcommitted
USB: serial: ti_usb_3410_5052: use strscpy() instead of strcpy()
Use a safer function strscpy() instead of strcpy() for copying to arrays. Only idiomatic code replacement, and no functional changes. Signed-off-by: Ai Chao <aichao@kylinos.cn> Signed-off-by: Johan Hovold <johan@kernel.org>
1 parent f338e77 commit 5a6a33b

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/usb/serial/ti_usb_3410_5052.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1600,29 +1600,29 @@ static int ti_download_firmware(struct ti_device *tdev)
16001600
if (le16_to_cpu(dev->descriptor.idVendor) == MTS_VENDOR_ID) {
16011601
switch (le16_to_cpu(dev->descriptor.idProduct)) {
16021602
case MTS_CDMA_PRODUCT_ID:
1603-
strcpy(buf, "mts_cdma.fw");
1603+
strscpy(buf, "mts_cdma.fw");
16041604
break;
16051605
case MTS_GSM_PRODUCT_ID:
1606-
strcpy(buf, "mts_gsm.fw");
1606+
strscpy(buf, "mts_gsm.fw");
16071607
break;
16081608
case MTS_EDGE_PRODUCT_ID:
1609-
strcpy(buf, "mts_edge.fw");
1609+
strscpy(buf, "mts_edge.fw");
16101610
break;
16111611
case MTS_MT9234MU_PRODUCT_ID:
1612-
strcpy(buf, "mts_mt9234mu.fw");
1612+
strscpy(buf, "mts_mt9234mu.fw");
16131613
break;
16141614
case MTS_MT9234ZBA_PRODUCT_ID:
1615-
strcpy(buf, "mts_mt9234zba.fw");
1615+
strscpy(buf, "mts_mt9234zba.fw");
16161616
break;
16171617
case MTS_MT9234ZBAOLD_PRODUCT_ID:
1618-
strcpy(buf, "mts_mt9234zba.fw");
1618+
strscpy(buf, "mts_mt9234zba.fw");
16191619
break; }
16201620
}
16211621
if (buf[0] == '\0') {
16221622
if (tdev->td_is_3410)
1623-
strcpy(buf, "ti_3410.fw");
1623+
strscpy(buf, "ti_3410.fw");
16241624
else
1625-
strcpy(buf, "ti_5052.fw");
1625+
strscpy(buf, "ti_5052.fw");
16261626
}
16271627
status = request_firmware(&fw_p, buf, &dev->dev);
16281628
}

0 commit comments

Comments
 (0)