Skip to content

Commit 599bbba

Browse files
committed
proc: make PROC_MEM_FORCE_PTRACE the Kconfig default
This kconfig option was introduced 18 months ago, with the historical default of always allowing forcing memory permission overrides in order to not change any existing behavior. But it was documented as "for now", and this is a gentle nudge to people that you probably _should_ be using PROC_MEM_FORCE_PTRACE. I've had that in my local kernel config since the option was introduced. Anybody who just does "make oldconfig" will pick up their old configuration with no change, so this is still meant to not change any existing system behavior, but at least gently prod people into trying it. I'd love to get rid of FOLL_FORCE entirely (see commit 8ee74a9 "proc: try to remove use of FOLL_FORCE entirely" from roughly a decade ago), but sadly that is likely not a realistic option (see commit f511c0b "Yes, people use FOLL_FORCE ;)" three weeks later). But at least let's make it more obvious that you have the choice to limit it and force people to at least be a bit more conscious about their use of FOLL_FORCE, since judging from a recent discussion people weren't even aware of this one. Reminded-by: Vova Tokarev <vladimirelitokarev@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent fdcbb1b commit 599bbba

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

security/Kconfig

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,14 @@ config SECURITY_DMESG_RESTRICT
2121

2222
choice
2323
prompt "Allow /proc/pid/mem access override"
24-
default PROC_MEM_ALWAYS_FORCE
24+
default PROC_MEM_FORCE_PTRACE
2525
help
2626
Traditionally /proc/pid/mem allows users to override memory
2727
permissions for users like ptrace, assuming they have ptrace
2828
capability.
2929

3030
This allows people to limit that - either never override, or
31-
require actual active ptrace attachment.
32-
33-
Defaults to the traditional behavior (for now)
31+
require actual active ptrace attachment (default).
3432

3533
config PROC_MEM_ALWAYS_FORCE
3634
bool "Traditional /proc/pid/mem behavior"

0 commit comments

Comments
 (0)