Skip to content

Commit 5886cc8

Browse files
t-8chlumag
authored andcommitted
drm/msm/dpu: Don't use %pK through printk (again)
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping locks in atomic contexts. Switch to the regular pointer formatting which is safer and easier to reason about. This was previously fixed in this driver in commit 1ba9fbe ("drm/msm: Don't use %pK through printk") but an additional usage was reintroduced in commit 39a750f ("drm/msm/dpu: Add DSPP GC driver to provide GAMMA_LUT DRM property") Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Fixes: 39a750f ("drm/msm/dpu: Add DSPP GC driver to provide GAMMA_LUT DRM property") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/706229/ Link: https://lore.kernel.org/r/20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent 9f59341 commit 5886cc8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ static void dpu_setup_dspp_gc(struct dpu_hw_dspp *ctx,
8989
base = ctx->cap->sblk->gc.base;
9090

9191
if (!base) {
92-
DRM_ERROR("invalid ctx %pK gc base\n", ctx);
92+
DRM_ERROR("invalid ctx %p gc base\n", ctx);
9393
return;
9494
}
9595

0 commit comments

Comments
 (0)