Skip to content

Commit 54549af

Browse files
Chen NiJiri Kosina
authored andcommitted
HID: hid-lenovo-go: Remove unneeded semicolon
Remove unnecessary semicolons after switch statements and function bodies. Most issues were reported by Coccinelle/coccicheck using the semantic patch at scripts/coccinelle/misc/semicolon.cocci. Additional instances found during manual code review were also fixed. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent c047440 commit 54549af

1 file changed

Lines changed: 26 additions & 26 deletions

File tree

drivers/hid/hid-lenovo-go.c

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ static int hid_go_feature_status_event(struct command_report *cmd_rep)
455455
return 0;
456456
default:
457457
return -EINVAL;
458-
};
458+
}
459459
case FEATURE_IMU_BYPASS:
460460
switch (cmd_rep->device_type) {
461461
case LEFT_CONTROLLER:
@@ -466,7 +466,7 @@ static int hid_go_feature_status_event(struct command_report *cmd_rep)
466466
return 0;
467467
default:
468468
return -EINVAL;
469-
};
469+
}
470470
break;
471471
case FEATURE_LIGHT_ENABLE:
472472
drvdata.rgb_en = cmd_rep->data[0];
@@ -481,7 +481,7 @@ static int hid_go_feature_status_event(struct command_report *cmd_rep)
481481
return 0;
482482
default:
483483
return -EINVAL;
484-
};
484+
}
485485
break;
486486
case FEATURE_TOUCHPAD_ENABLE:
487487
drvdata.tp_en = cmd_rep->data[0];
@@ -515,7 +515,7 @@ static int hid_go_motor_event(struct command_report *cmd_rep)
515515
return 0;
516516
default:
517517
return -EINVAL;
518-
};
518+
}
519519
break;
520520
case RUMBLE_MODE:
521521
switch (cmd_rep->device_type) {
@@ -527,7 +527,7 @@ static int hid_go_motor_event(struct command_report *cmd_rep)
527527
return 0;
528528
default:
529529
return -EINVAL;
530-
};
530+
}
531531
case TP_VIBRATION_ENABLE:
532532
drvdata.tp_vibration_en = cmd_rep->data[0];
533533
return 0;
@@ -625,7 +625,7 @@ static int hid_go_os_mode_cfg_event(struct command_report *cmd_rep)
625625
return 0;
626626
default:
627627
return -EINVAL;
628-
};
628+
}
629629
}
630630

631631
static int hid_go_set_event_return(struct command_report *cmd_rep)
@@ -699,14 +699,14 @@ static int hid_go_raw_event(struct hid_device *hdev, struct hid_report *report,
699699
default:
700700
ret = -EINVAL;
701701
break;
702-
};
702+
}
703703
break;
704704
case OS_MODE_DATA:
705705
ret = hid_go_os_mode_cfg_event(cmd_rep);
706706
break;
707707
default:
708708
goto passthrough;
709-
};
709+
}
710710
dev_dbg(&hdev->dev, "Rx data as raw input report: [%*ph]\n",
711711
GO_PACKET_SIZE, data);
712712

@@ -925,7 +925,7 @@ static ssize_t feature_status_store(struct device *dev,
925925
break;
926926
default:
927927
return -EINVAL;
928-
};
928+
}
929929

930930
if (ret < 0)
931931
return ret;
@@ -1013,7 +1013,7 @@ static ssize_t feature_status_show(struct device *dev,
10131013
break;
10141014
default:
10151015
return -EINVAL;
1016-
};
1016+
}
10171017
count = sysfs_emit(buf, "%u\n", i);
10181018
break;
10191019
case FEATURE_FPS_SWITCH_STATUS:
@@ -1032,7 +1032,7 @@ static ssize_t feature_status_show(struct device *dev,
10321032
break;
10331033
default:
10341034
return -EINVAL;
1035-
};
1035+
}
10361036

10371037
return count;
10381038
}
@@ -1070,7 +1070,7 @@ static ssize_t feature_status_options(struct device *dev,
10701070
break;
10711071
default:
10721072
return -EINVAL;
1073-
};
1073+
}
10741074

10751075
if (count)
10761076
buf[count - 1] = '\n';
@@ -1111,7 +1111,7 @@ static ssize_t motor_config_store(struct device *dev,
11111111
ret = sysfs_match_string(intensity_text, buf);
11121112
val = ret;
11131113
break;
1114-
};
1114+
}
11151115

11161116
if (ret < 0)
11171117
return ret;
@@ -1161,7 +1161,7 @@ static ssize_t motor_config_show(struct device *dev,
11611161
break;
11621162
default:
11631163
return -EINVAL;
1164-
};
1164+
}
11651165
if (i >= ARRAY_SIZE(enabled_status_text))
11661166
return -EINVAL;
11671167

@@ -1177,7 +1177,7 @@ static ssize_t motor_config_show(struct device *dev,
11771177
break;
11781178
default:
11791179
return -EINVAL;
1180-
};
1180+
}
11811181
if (i >= ARRAY_SIZE(rumble_mode_text))
11821182
return -EINVAL;
11831183

@@ -1197,7 +1197,7 @@ static ssize_t motor_config_show(struct device *dev,
11971197

11981198
count = sysfs_emit(buf, "%s\n", intensity_text[i]);
11991199
break;
1200-
};
1200+
}
12011201

12021202
return count;
12031203
}
@@ -1232,7 +1232,7 @@ static ssize_t motor_config_options(struct device *dev,
12321232
enabled_status_text[i]);
12331233
}
12341234
break;
1235-
};
1235+
}
12361236

12371237
if (count)
12381238
buf[count - 1] = '\n';
@@ -1333,7 +1333,7 @@ static ssize_t device_status_show(struct device *dev,
13331333
break;
13341334
default:
13351335
return -EINVAL;
1336-
};
1336+
}
13371337

13381338
if (i >= ARRAY_SIZE(cal_status_text))
13391339
return -EINVAL;
@@ -1459,7 +1459,7 @@ static int rgb_attr_show(void)
14591459
index = drvdata.rgb_profile + 3;
14601460

14611461
return rgb_cfg_call(drvdata.hdev, GET_RGB_CFG, index, NULL, 0);
1462-
};
1462+
}
14631463

14641464
static ssize_t rgb_effect_store(struct device *dev,
14651465
struct device_attribute *attr, const char *buf,
@@ -1489,7 +1489,7 @@ static ssize_t rgb_effect_store(struct device *dev,
14891489

14901490
drvdata.rgb_effect = effect;
14911491
return count;
1492-
};
1492+
}
14931493

14941494
static ssize_t rgb_effect_show(struct device *dev,
14951495
struct device_attribute *attr, char *buf)
@@ -1555,7 +1555,7 @@ static ssize_t rgb_speed_store(struct device *dev,
15551555
drvdata.rgb_speed = val;
15561556

15571557
return count;
1558-
};
1558+
}
15591559

15601560
static ssize_t rgb_speed_show(struct device *dev, struct device_attribute *attr,
15611561
char *buf)
@@ -1599,7 +1599,7 @@ static ssize_t rgb_mode_store(struct device *dev, struct device_attribute *attr,
15991599
drvdata.rgb_mode = val;
16001600

16011601
return count;
1602-
};
1602+
}
16031603

16041604
static ssize_t rgb_mode_show(struct device *dev, struct device_attribute *attr,
16051605
char *buf)
@@ -1614,7 +1614,7 @@ static ssize_t rgb_mode_show(struct device *dev, struct device_attribute *attr,
16141614
return -EINVAL;
16151615

16161616
return sysfs_emit(buf, "%s\n", rgb_mode_text[drvdata.rgb_mode]);
1617-
};
1617+
}
16181618

16191619
static ssize_t rgb_mode_index_show(struct device *dev,
16201620
struct device_attribute *attr, char *buf)
@@ -1653,7 +1653,7 @@ static ssize_t rgb_profile_store(struct device *dev,
16531653
drvdata.rgb_profile = val;
16541654

16551655
return count;
1656-
};
1656+
}
16571657

16581658
static ssize_t rgb_profile_show(struct device *dev,
16591659
struct device_attribute *attr, char *buf)
@@ -1668,7 +1668,7 @@ static ssize_t rgb_profile_show(struct device *dev,
16681668
return -EINVAL;
16691669

16701670
return sysfs_emit(buf, "%hhu\n", drvdata.rgb_profile);
1671-
};
1671+
}
16721672

16731673
static ssize_t rgb_profile_range_show(struct device *dev,
16741674
struct device_attribute *attr, char *buf)
@@ -1707,7 +1707,7 @@ static void hid_go_brightness_set(struct led_classdev *led_cdev,
17071707
break;
17081708
default:
17091709
dev_err(led_cdev->dev, "Failed to write RGB profile: %i\n", ret);
1710-
};
1710+
}
17111711
}
17121712

17131713
#define LEGO_DEVICE_ATTR_RW(_name, _attrname, _dtype, _rtype, _group) \

0 commit comments

Comments
 (0)