Skip to content

Commit 511dc89

Browse files
maharmstonekdave
authored andcommitted
btrfs: fix incorrect key offset in error message in check_dev_extent_item()
Fix the error message in check_dev_extent_item(), when an overlapping stripe is encountered. For dev extents, objectid is the disk number and offset the physical address, so prev_key->objectid should actually be prev_key->offset. (I can't take any credit for this one - this was discovered by Chris and his friend Claude.) Reported-by: Chris Mason <clm@fb.com> Fixes: 008e251 ("btrfs: tree-checker: add dev extent item checks") Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Mark Harmstone <mark@harmstone.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 3cf0f35 commit 511dc89

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/btrfs/tree-checker.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1921,7 +1921,7 @@ static int check_dev_extent_item(const struct extent_buffer *leaf,
19211921
if (unlikely(prev_key->offset + prev_len > key->offset)) {
19221922
generic_err(leaf, slot,
19231923
"dev extent overlap, prev offset %llu len %llu current offset %llu",
1924-
prev_key->objectid, prev_len, key->offset);
1924+
prev_key->offset, prev_len, key->offset);
19251925
return -EUCLEAN;
19261926
}
19271927
}

0 commit comments

Comments
 (0)