Skip to content

Commit 510a750

Browse files
josephhzakpm00
authored andcommitted
ocfs2: remove redundant l_next_free_rec check in __ocfs2_find_path()
The l_next_free_rec > l_count check after ocfs2_read_extent_block() in __ocfs2_find_path() is now redundant, as ocfs2_validate_extent_block() already performs this validation at block read time. Remove the duplicate check to avoid maintaining the same validation in two places. Link: https://lkml.kernel.org/r/20260403090803.3860971-5-joseph.qi@linux.alibaba.com Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com> Reviewed-by: Heming Zhao <heming.zhao@suse.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Joel Becker <jlbec@evilplan.org> Cc: Jun Piao <piaojun@huawei.com> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Mark Fasheh <mark@fasheh.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent af5e456 commit 510a750

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

fs/ocfs2/alloc.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1878,18 +1878,6 @@ static int __ocfs2_find_path(struct ocfs2_caching_info *ci,
18781878
eb = (struct ocfs2_extent_block *) bh->b_data;
18791879
el = &eb->h_list;
18801880

1881-
if (le16_to_cpu(el->l_next_free_rec) >
1882-
le16_to_cpu(el->l_count)) {
1883-
ocfs2_error(ocfs2_metadata_cache_get_super(ci),
1884-
"Owner %llu has bad count in extent list at block %llu (next free=%u, count=%u)\n",
1885-
(unsigned long long)ocfs2_metadata_cache_owner(ci),
1886-
(unsigned long long)bh->b_blocknr,
1887-
le16_to_cpu(el->l_next_free_rec),
1888-
le16_to_cpu(el->l_count));
1889-
ret = -EROFS;
1890-
goto out;
1891-
}
1892-
18931881
if (func)
18941882
func(data, bh);
18951883
}

0 commit comments

Comments
 (0)