Skip to content

Commit 4dd05f0

Browse files
samasth-norwaydavejiang
authored andcommitted
cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON
Remove the outdated FIXME comment about switching to struct_group() and the associated BUILD_BUG_ON check. This work was already completed in commit 301e68d ("cxl/core: Replace unions with struct_group()") which converted struct cxl_regs to use struct_group_tagged(). The BUILD_BUG_ON was checking that anonymous union layout was preserved, but since struct_group() now handles this correctly, the compile-time check is no longer necessary. Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Link: https://patch.msgid.link/20260105203833.1604585-1-samasth.norway.ananda@oracle.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent 7362fac commit 4dd05f0

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

drivers/cxl/pci.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -912,13 +912,6 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
912912
unsigned int i;
913913
bool irq_avail;
914914

915-
/*
916-
* Double check the anonymous union trickery in struct cxl_regs
917-
* FIXME switch to struct_group()
918-
*/
919-
BUILD_BUG_ON(offsetof(struct cxl_regs, memdev) !=
920-
offsetof(struct cxl_regs, device_regs.memdev));
921-
922915
rc = pcim_enable_device(pdev);
923916
if (rc)
924917
return rc;

0 commit comments

Comments
 (0)