Skip to content

Commit 4ce1f19

Browse files
committed
clk: composite: convert from round_rate() to determine_rate()
The round_rate() clk ops is deprecated and going away, so migrate this driver from round_rate() to determine_rate(). Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent e270dc6 commit 4ce1f19

1 file changed

Lines changed: 5 additions & 33 deletions

File tree

drivers/clk/clk-composite.c

Lines changed: 5 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -47,22 +47,10 @@ static int clk_composite_determine_rate_for_parent(struct clk_hw *rate_hw,
4747
struct clk_hw *parent_hw,
4848
const struct clk_ops *rate_ops)
4949
{
50-
long rate;
51-
5250
req->best_parent_hw = parent_hw;
5351
req->best_parent_rate = clk_hw_get_rate(parent_hw);
5452

55-
if (rate_ops->determine_rate)
56-
return rate_ops->determine_rate(rate_hw, req);
57-
58-
rate = rate_ops->round_rate(rate_hw, req->rate,
59-
&req->best_parent_rate);
60-
if (rate < 0)
61-
return rate;
62-
63-
req->rate = rate;
64-
65-
return 0;
53+
return rate_ops->determine_rate(rate_hw, req);
6654
}
6755

6856
static int clk_composite_determine_rate(struct clk_hw *hw,
@@ -79,8 +67,7 @@ static int clk_composite_determine_rate(struct clk_hw *hw,
7967
unsigned long best_rate = 0;
8068
int i, ret;
8169

82-
if (rate_hw && rate_ops &&
83-
(rate_ops->determine_rate || rate_ops->round_rate) &&
70+
if (rate_hw && rate_ops && rate_ops->determine_rate &&
8471
mux_hw && mux_ops && mux_ops->set_parent) {
8572
req->best_parent_hw = NULL;
8673

@@ -150,18 +137,6 @@ static int clk_composite_determine_rate(struct clk_hw *hw,
150137
}
151138
}
152139

153-
static long clk_composite_round_rate(struct clk_hw *hw, unsigned long rate,
154-
unsigned long *prate)
155-
{
156-
struct clk_composite *composite = to_clk_composite(hw);
157-
const struct clk_ops *rate_ops = composite->rate_ops;
158-
struct clk_hw *rate_hw = composite->rate_hw;
159-
160-
__clk_hw_set_clk(rate_hw, hw);
161-
162-
return rate_ops->round_rate(rate_hw, rate, prate);
163-
}
164-
165140
static int clk_composite_set_rate(struct clk_hw *hw, unsigned long rate,
166141
unsigned long parent_rate)
167142
{
@@ -288,17 +263,14 @@ static struct clk_hw *__clk_hw_register_composite(struct device *dev,
288263
if (rate_ops->determine_rate)
289264
clk_composite_ops->determine_rate =
290265
clk_composite_determine_rate;
291-
else if (rate_ops->round_rate)
292-
clk_composite_ops->round_rate =
293-
clk_composite_round_rate;
294266

295-
/* .set_rate requires either .round_rate or .determine_rate */
267+
/* .set_rate requires .determine_rate */
296268
if (rate_ops->set_rate) {
297-
if (rate_ops->determine_rate || rate_ops->round_rate)
269+
if (rate_ops->determine_rate)
298270
clk_composite_ops->set_rate =
299271
clk_composite_set_rate;
300272
else
301-
WARN(1, "%s: missing round_rate op is required\n",
273+
WARN(1, "%s: missing determine_rate op is required\n",
302274
__func__);
303275
}
304276

0 commit comments

Comments
 (0)