Skip to content

Commit 4a768c5

Browse files
vmyakovlevsuperna9999
authored andcommitted
drm/panel: himax-hx83102: change to gpiod_set_value_cansleep
It's better to use gpiod_set_value_cansleep because the panel can be connected via i2c/spi expander or similar external devices for reference see Documentation/driver-api/gpio/consumer.rst Signed-off-by: Vladimir Yakovlev <vovchkir@gmail.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patch.msgid.link/20251208161613.3763049-1-vovchkir@gmail.com
1 parent 94ccf74 commit 4a768c5

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/gpu/drm/panel/panel-himax-hx83102.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,7 @@ static int hx83102_unprepare(struct drm_panel *panel)
859859
{
860860
struct hx83102 *ctx = panel_to_hx83102(panel);
861861

862-
gpiod_set_value(ctx->enable_gpio, 0);
862+
gpiod_set_value_cansleep(ctx->enable_gpio, 0);
863863
usleep_range(1000, 2000);
864864
regulator_disable(ctx->avee);
865865
regulator_disable(ctx->avdd);
@@ -875,7 +875,7 @@ static int hx83102_prepare(struct drm_panel *panel)
875875
struct mipi_dsi_device *dsi = ctx->dsi;
876876
struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
877877

878-
gpiod_set_value(ctx->enable_gpio, 0);
878+
gpiod_set_value_cansleep(ctx->enable_gpio, 0);
879879
usleep_range(1000, 1500);
880880

881881
dsi_ctx.accum_err = regulator_enable(ctx->pp1800);
@@ -899,11 +899,11 @@ static int hx83102_prepare(struct drm_panel *panel)
899899

900900
usleep_range(1000, 2000);
901901

902-
gpiod_set_value(ctx->enable_gpio, 1);
902+
gpiod_set_value_cansleep(ctx->enable_gpio, 1);
903903
usleep_range(1000, 2000);
904-
gpiod_set_value(ctx->enable_gpio, 0);
904+
gpiod_set_value_cansleep(ctx->enable_gpio, 0);
905905
usleep_range(1000, 2000);
906-
gpiod_set_value(ctx->enable_gpio, 1);
906+
gpiod_set_value_cansleep(ctx->enable_gpio, 1);
907907
usleep_range(6000, 10000);
908908

909909
dsi_ctx.accum_err = ctx->desc->init(ctx);
@@ -917,7 +917,7 @@ static int hx83102_prepare(struct drm_panel *panel)
917917
return 0;
918918

919919
poweroff:
920-
gpiod_set_value(ctx->enable_gpio, 0);
920+
gpiod_set_value_cansleep(ctx->enable_gpio, 0);
921921
regulator_disable(ctx->avee);
922922
poweroffavdd:
923923
regulator_disable(ctx->avdd);

0 commit comments

Comments
 (0)