Skip to content

Commit 44a95ff

Browse files
committed
drm/i915/dp: Factor out align_max_vesa_compressed_bpp_x16()
Factor out align_max_vesa_compressed_bpp_x16(), also used later for computing the maximum DSC compressed BPP limit. Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> Reviewed-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patch.msgid.link/20251222153547.713360-5-imre.deak@intel.com
1 parent 85b4360 commit 44a95ff

1 file changed

Lines changed: 20 additions & 15 deletions

File tree

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -868,10 +868,23 @@ small_joiner_ram_size_bits(struct intel_display *display)
868868
return 6144 * 8;
869869
}
870870

871+
static int align_max_vesa_compressed_bpp_x16(int max_link_bpp_x16)
872+
{
873+
int i;
874+
875+
for (i = ARRAY_SIZE(valid_dsc_bpp) - 1; i >= 0; i--) {
876+
int vesa_bpp_x16 = fxp_q4_from_int(valid_dsc_bpp[i]);
877+
878+
if (vesa_bpp_x16 <= max_link_bpp_x16)
879+
return vesa_bpp_x16;
880+
}
881+
882+
return 0;
883+
}
884+
871885
static u32 intel_dp_dsc_nearest_valid_bpp(struct intel_display *display, u32 bpp, u32 pipe_bpp)
872886
{
873887
u32 bits_per_pixel = bpp;
874-
int i;
875888

876889
/* Error out if the max bpp is less than smallest allowed valid bpp */
877890
if (bits_per_pixel < valid_dsc_bpp[0]) {
@@ -900,15 +913,13 @@ static u32 intel_dp_dsc_nearest_valid_bpp(struct intel_display *display, u32 bpp
900913
}
901914
bits_per_pixel = min_t(u32, bits_per_pixel, 27);
902915
} else {
916+
int link_bpp_x16 = fxp_q4_from_int(bits_per_pixel);
917+
903918
/* Find the nearest match in the array of known BPPs from VESA */
904-
for (i = 0; i < ARRAY_SIZE(valid_dsc_bpp) - 1; i++) {
905-
if (bits_per_pixel < valid_dsc_bpp[i + 1])
906-
break;
907-
}
908-
drm_dbg_kms(display->drm, "Set dsc bpp from %d to VESA %d\n",
909-
bits_per_pixel, valid_dsc_bpp[i]);
919+
link_bpp_x16 = align_max_vesa_compressed_bpp_x16(link_bpp_x16);
910920

911-
bits_per_pixel = valid_dsc_bpp[i];
921+
drm_WARN_ON(display->drm, fxp_q4_to_frac(link_bpp_x16));
922+
bits_per_pixel = fxp_q4_to_int(link_bpp_x16);
912923
}
913924

914925
return bits_per_pixel;
@@ -2220,7 +2231,6 @@ int intel_dp_dsc_bpp_step_x16(const struct intel_connector *connector)
22202231
bool intel_dp_dsc_valid_compressed_bpp(struct intel_dp *intel_dp, int bpp_x16)
22212232
{
22222233
struct intel_display *display = to_intel_display(intel_dp);
2223-
int i;
22242234

22252235
if (DISPLAY_VER(display) >= 13) {
22262236
if (intel_dp->force_dsc_fractional_bpp_en && !fxp_q4_to_frac(bpp_x16))
@@ -2232,12 +2242,7 @@ bool intel_dp_dsc_valid_compressed_bpp(struct intel_dp *intel_dp, int bpp_x16)
22322242
if (fxp_q4_to_frac(bpp_x16))
22332243
return false;
22342244

2235-
for (i = 0; i < ARRAY_SIZE(valid_dsc_bpp); i++) {
2236-
if (fxp_q4_to_int(bpp_x16) == valid_dsc_bpp[i])
2237-
return true;
2238-
}
2239-
2240-
return false;
2245+
return align_max_vesa_compressed_bpp_x16(bpp_x16) == bpp_x16;
22412246
}
22422247

22432248
/*

0 commit comments

Comments
 (0)