Skip to content

Commit 3fd2058

Browse files
hkasivisalexdeucher
authored andcommitted
drm/amdkfd: No need to suspend whole MES to evict process
Each queue of the process is individually removed and there is not need to suspend whole mes. Suspending mes stops kernel mode queues also causing unnecessary timeouts when running mixed work loads Fixes: 079ae51 ("drm/amdkfd: fix suspend/resume all calls in mes based eviction path") Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4765 Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent e921a5f commit 3fd2058

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,14 +1211,8 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
12111211
pr_debug_ratelimited("Evicting process pid %d queues\n",
12121212
pdd->process->lead_thread->pid);
12131213

1214-
if (dqm->dev->kfd->shared_resources.enable_mes) {
1214+
if (dqm->dev->kfd->shared_resources.enable_mes)
12151215
pdd->last_evict_timestamp = get_jiffies_64();
1216-
retval = suspend_all_queues_mes(dqm);
1217-
if (retval) {
1218-
dev_err(dev, "Suspending all queues failed");
1219-
goto out;
1220-
}
1221-
}
12221216

12231217
/* Mark all queues as evicted. Deactivate all active queues on
12241218
* the qpd.
@@ -1248,10 +1242,6 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
12481242
KFD_UNMAP_QUEUES_FILTER_ALL_QUEUES :
12491243
KFD_UNMAP_QUEUES_FILTER_DYNAMIC_QUEUES, 0,
12501244
USE_DEFAULT_GRACE_PERIOD);
1251-
} else {
1252-
retval = resume_all_queues_mes(dqm);
1253-
if (retval)
1254-
dev_err(dev, "Resuming all queues failed");
12551245
}
12561246

12571247
out:

0 commit comments

Comments
 (0)