Skip to content

Commit 3e29889

Browse files
bugjoshsmfrench
authored andcommitted
ksmbd: fix use-after-free from async crypto on Qualcomm crypto engine
ksmbd_crypt_message() sets a NULL completion callback on AEAD requests and does not handle the -EINPROGRESS return code from async hardware crypto engines like the Qualcomm Crypto Engine (QCE). When QCE returns -EINPROGRESS, ksmbd treats it as an error and immediately frees the request while the hardware DMA operation is still in flight. The DMA completion callback then dereferences freed memory, causing a NULL pointer crash: pc : qce_skcipher_done+0x24/0x174 lr : vchan_complete+0x230/0x27c ... el1h_64_irq+0x68/0x6c ksmbd_free_work_struct+0x20/0x118 [ksmbd] ksmbd_exit_file_cache+0x694/0xa4c [ksmbd] Use the standard crypto_wait_req() pattern with crypto_req_done() as the completion callback, matching the approach used by the SMB client in fs/smb/client/smb2ops.c. This properly handles both synchronous engines (immediate return) and async engines (-EINPROGRESS followed by callback notification). Fixes: e2f3448 ("cifsd: add server-side procedures for SMB3") Link: openwrt/openwrt#21822 Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent ad0057f commit 3e29889

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

fs/smb/server/auth.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -827,6 +827,7 @@ int ksmbd_crypt_message(struct ksmbd_work *work, struct kvec *iov,
827827
struct smb2_transform_hdr *tr_hdr = smb_get_msg(iov[0].iov_base);
828828
unsigned int assoc_data_len = sizeof(struct smb2_transform_hdr) - 20;
829829
int rc;
830+
DECLARE_CRYPTO_WAIT(wait);
830831
struct scatterlist *sg;
831832
u8 sign[SMB2_SIGNATURE_SIZE] = {};
832833
u8 key[SMB3_ENC_DEC_KEY_SIZE];
@@ -913,12 +914,12 @@ int ksmbd_crypt_message(struct ksmbd_work *work, struct kvec *iov,
913914

914915
aead_request_set_crypt(req, sg, sg, crypt_len, iv);
915916
aead_request_set_ad(req, assoc_data_len);
916-
aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP, NULL, NULL);
917+
aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG |
918+
CRYPTO_TFM_REQ_MAY_SLEEP,
919+
crypto_req_done, &wait);
917920

918-
if (enc)
919-
rc = crypto_aead_encrypt(req);
920-
else
921-
rc = crypto_aead_decrypt(req);
921+
rc = crypto_wait_req(enc ? crypto_aead_encrypt(req) :
922+
crypto_aead_decrypt(req), &wait);
922923
if (rc)
923924
goto free_iv;
924925

0 commit comments

Comments
 (0)