Skip to content

Commit 32eab46

Browse files
committed
drm/xe/soc_remapper: Use SoC remapper helper from VSEC code
Since different drivers can use SoC remapper, modify VSEC code to access SoC remapper via a helper that would synchronize such accesses. Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> Reviewed-by: Badal Nilawar <badal.nilawar@intel.com> Link: https://patch.msgid.link/20251223183943.3175941-7-umesh.nerlige.ramappa@intel.com
1 parent a9f88c6 commit 32eab46

7 files changed

Lines changed: 45 additions & 6 deletions

File tree

drivers/gpu/drm/xe/regs/xe_pmt.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
#define BMG_TELEMETRY_BASE_OFFSET 0xE0000
1919
#define BMG_TELEMETRY_OFFSET (SOC_BASE + BMG_TELEMETRY_BASE_OFFSET)
2020

21-
#define SG_REMAP_INDEX1 XE_REG(SOC_BASE + 0x08)
22-
#define SG_REMAP_BITS REG_GENMASK(31, 24)
23-
2421
#define BMG_MODS_RESIDENCY_OFFSET (0x4D0)
2522
#define BMG_G2_RESIDENCY_OFFSET (0x530)
2623
#define BMG_G6_RESIDENCY_OFFSET (0x538)
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
/* SPDX-License-Identifier: MIT */
2+
/*
3+
* Copyright © 2025 Intel Corporation
4+
*/
5+
#ifndef _XE_SOC_REMAPPER_REGS_H_
6+
#define _XE_SOC_REMAPPER_REGS_H_
7+
8+
#include "xe_regs.h"
9+
10+
#define SG_REMAP_INDEX1 XE_REG(SOC_BASE + 0x08)
11+
#define SG_REMAP_TELEM_MASK REG_GENMASK(31, 24)
12+
13+
#endif

drivers/gpu/drm/xe/xe_device_types.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,8 @@ struct xe_device {
334334
u8 has_pxp:1;
335335
/** @info.has_range_tlb_inval: Has range based TLB invalidations */
336336
u8 has_range_tlb_inval:1;
337+
/** @info.has_soc_remapper_telem: Has SoC remapper telemetry support */
338+
u8 has_soc_remapper_telem:1;
337339
/** @info.has_sriov: Supports SR-IOV */
338340
u8 has_sriov:1;
339341
/** @info.has_usm: Device has unified shared memory support */
@@ -582,6 +584,9 @@ struct xe_device {
582584
struct {
583585
/** @soc_remapper.lock: Serialize access to SoC Remapper's index registers */
584586
spinlock_t lock;
587+
588+
/** @soc_remapper.set_telem_region: Set telemetry index */
589+
void (*set_telem_region)(struct xe_device *xe, u32 index);
585590
} soc_remapper;
586591

587592
/**

drivers/gpu/drm/xe/xe_pci.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,7 @@ static const struct xe_device_desc bmg_desc = {
370370
.has_i2c = true,
371371
.has_late_bind = true,
372372
.has_pre_prod_wa = 1,
373+
.has_soc_remapper_telem = true,
373374
.has_sriov = true,
374375
.has_mem_copy_instr = true,
375376
.max_gt_per_tile = 2,
@@ -421,6 +422,7 @@ static const struct xe_device_desc cri_desc = {
421422
.has_mbx_power_limits = true,
422423
.has_mert = true,
423424
.has_pre_prod_wa = 1,
425+
.has_soc_remapper_telem = true,
424426
.has_sriov = true,
425427
.max_gt_per_tile = 2,
426428
.require_force_probe = true,
@@ -692,6 +694,7 @@ static int xe_info_init_early(struct xe_device *xe,
692694
xe->info.has_page_reclaim_hw_assist = desc->has_page_reclaim_hw_assist;
693695
xe->info.has_pre_prod_wa = desc->has_pre_prod_wa;
694696
xe->info.has_pxp = desc->has_pxp;
697+
xe->info.has_soc_remapper_telem = desc->has_soc_remapper_telem;
695698
xe->info.has_sriov = xe_configfs_primary_gt_allowed(to_pci_dev(xe->drm.dev)) &&
696699
desc->has_sriov;
697700
xe->info.has_mem_copy_instr = desc->has_mem_copy_instr;

drivers/gpu/drm/xe/xe_pci_types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ struct xe_device_desc {
5353
u8 has_pre_prod_wa:1;
5454
u8 has_page_reclaim_hw_assist:1;
5555
u8 has_pxp:1;
56+
u8 has_soc_remapper_telem:1;
5657
u8 has_sriov:1;
5758
u8 needs_scratch:1;
5859
u8 skip_guc_pc:1;

drivers/gpu/drm/xe/xe_soc_remapper.c

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,23 @@
33
* Copyright © 2025 Intel Corporation
44
*/
55

6+
#include "regs/xe_soc_remapper_regs.h"
7+
#include "xe_mmio.h"
68
#include "xe_soc_remapper.h"
79

10+
static void xe_soc_remapper_set_region(struct xe_device *xe, struct xe_reg reg,
11+
u32 mask, u32 val)
12+
{
13+
guard(spinlock_irqsave)(&xe->soc_remapper.lock);
14+
xe_mmio_rmw32(xe_root_tile_mmio(xe), reg, mask, val);
15+
}
16+
17+
static void xe_soc_remapper_set_telem_region(struct xe_device *xe, u32 index)
18+
{
19+
xe_soc_remapper_set_region(xe, SG_REMAP_INDEX1, SG_REMAP_TELEM_MASK,
20+
REG_FIELD_PREP(SG_REMAP_TELEM_MASK, index));
21+
}
22+
823
/**
924
* xe_soc_remapper_init() - Initialize SoC remapper
1025
* @xe: Pointer to xe device.
@@ -15,7 +30,10 @@
1530
*/
1631
int xe_soc_remapper_init(struct xe_device *xe)
1732
{
18-
spin_lock_init(&xe->soc_remapper.lock);
33+
if (xe->info.has_soc_remapper_telem) {
34+
spin_lock_init(&xe->soc_remapper.lock);
35+
xe->soc_remapper.set_telem_region = xe_soc_remapper_set_telem_region;
36+
}
1937

2038
return 0;
2139
}

drivers/gpu/drm/xe/xe_vsec.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,15 @@ int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_off
158158

159159
guard(mutex)(&xe->pmt.lock);
160160

161+
if (!xe->soc_remapper.set_telem_region)
162+
return -ENODEV;
163+
161164
/* indicate that we are not at an appropriate power level */
162165
if (!xe_pm_runtime_get_if_active(xe))
163166
return -ENODATA;
164167

165168
/* set SoC re-mapper index register based on GUID memory region */
166-
xe_mmio_rmw32(xe_root_tile_mmio(xe), SG_REMAP_INDEX1, SG_REMAP_BITS,
167-
REG_FIELD_PREP(SG_REMAP_BITS, mem_region));
169+
xe->soc_remapper.set_telem_region(xe, mem_region);
168170

169171
memcpy_fromio(data, telem_addr, count);
170172
xe_pm_runtime_put(xe);

0 commit comments

Comments
 (0)