Skip to content

Commit 2f529e7

Browse files
andrewstellmanakpm00
authored andcommitted
zram: reject unrecognized type= values in recompress_store()
recompress_store() parses the type= parameter with three if statements checking for "idle", "huge", and "huge_idle". An unrecognized value silently falls through with mode left at 0, causing the recompression pass to run with no slot filter — processing all slots instead of the intended subset. Add a !mode check after the type parsing block to return -EINVAL for unrecognized values, consistent with the function's other parameter validation. Link: https://lore.kernel.org/20260407153027.42425-1-astellman@stellman-greene.com Signed-off-by: Andrew Stellman <astellman@stellman-greene.com> Suggested-by: Sergey Senozhatsky <senozhatsky@chromium.org> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: Minchan Kim <minchan@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 9a8ea3c commit 2f529e7

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/block/zram/zram_drv.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2546,6 +2546,8 @@ static ssize_t recompress_store(struct device *dev,
25462546
mode = RECOMPRESS_HUGE;
25472547
if (!strcmp(val, "huge_idle"))
25482548
mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE;
2549+
if (!mode)
2550+
return -EINVAL;
25492551
continue;
25502552
}
25512553

0 commit comments

Comments
 (0)