Skip to content

Commit 2de35d9

Browse files
metze-sambasmfrench
authored andcommitted
smb: smbdirect: add some logging to SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}()
This should make it easier to analyze any possible problems. Cc: Steve French <smfrench@gmail.com> Cc: Tom Talpey <tom@talpey.com> Cc: Long Li <longli@microsoft.com> Cc: Namjae Jeon <linkinjeon@kernel.org> Cc: linux-cifs@vger.kernel.org Cc: samba-technical@lists.samba.org Signed-off-by: Stefan Metzmacher <metze@samba.org> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent c318239 commit 2de35d9

1 file changed

Lines changed: 20 additions & 1 deletion

File tree

fs/smb/common/smbdirect/smbdirect_socket.h

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,14 +563,33 @@ static __always_inline void smbdirect_socket_init(struct smbdirect_socket *sc)
563563

564564
#define __SMBDIRECT_CHECK_STATUS_WARN(__sc, __expected_status, __unexpected_cmd) \
565565
__SMBDIRECT_CHECK_STATUS_FAILED(__sc, __expected_status, \
566-
, \
567566
{ \
568567
const struct sockaddr_storage *__src = NULL; \
569568
const struct sockaddr_storage *__dst = NULL; \
570569
if ((__sc)->rdma.cm_id) { \
571570
__src = &(__sc)->rdma.cm_id->route.addr.src_addr; \
572571
__dst = &(__sc)->rdma.cm_id->route.addr.dst_addr; \
573572
} \
573+
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_INFO, \
574+
"expected[%s] != %s first_error=%1pe local=%pISpsfc remote=%pISpsfc\n", \
575+
smbdirect_socket_status_string(__expected_status), \
576+
smbdirect_socket_status_string((__sc)->status), \
577+
SMBDIRECT_DEBUG_ERR_PTR((__sc)->first_error), \
578+
__src, __dst); \
579+
}, \
580+
{ \
581+
const struct sockaddr_storage *__src = NULL; \
582+
const struct sockaddr_storage *__dst = NULL; \
583+
if ((__sc)->rdma.cm_id) { \
584+
__src = &(__sc)->rdma.cm_id->route.addr.src_addr; \
585+
__dst = &(__sc)->rdma.cm_id->route.addr.dst_addr; \
586+
} \
587+
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR, \
588+
"expected[%s] != %s first_error=%1pe local=%pISpsfc remote=%pISpsfc\n", \
589+
smbdirect_socket_status_string(__expected_status), \
590+
smbdirect_socket_status_string((__sc)->status), \
591+
SMBDIRECT_DEBUG_ERR_PTR((__sc)->first_error), \
592+
__src, __dst); \
574593
WARN_ONCE(1, \
575594
"expected[%s] != %s first_error=%1pe local=%pISpsfc remote=%pISpsfc\n", \
576595
smbdirect_socket_status_string(__expected_status), \

0 commit comments

Comments
 (0)